From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59310 invoked by alias); 19 Aug 2015 13:46:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 59283 invoked by uid 89); 19 Aug 2015 13:45:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 19 Aug 2015 13:45:56 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 364349D1F2; Wed, 19 Aug 2015 13:45:55 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t7JDjrR1013602; Wed, 19 Aug 2015 09:45:54 -0400 Message-ID: <55D48891.7050808@redhat.com> Date: Wed, 19 Aug 2015 13:46:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Luis Machado , gdb-patches@sourceware.org Subject: Re: [PATCH] Guard compile tests from running when unsupported + harden feature support check References: <1439988825-19754-1-git-send-email-lgustavo@codesourcery.com> <55D48179.2030000@redhat.com> <55D485D1.8040802@codesourcery.com> In-Reply-To: <55D485D1.8040802@codesourcery.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-08/txt/msg00514.txt.bz2 On 08/19/2015 02:34 PM, Luis Machado wrote: >> But please don't make us guess; please expand on when do you see this. > > It is related to how the binaries are built, without debug info. That's > how GDB reacts to these GCC 5.2-produced binaries. > ... > > Enabling debug info i see the standard error about missing libcc1, which > may be an alternate fix, though checking for unsupported languages does > sound useful to me. I disagree. It's a bug, because the tests are testing C code. > compile-ifunc.exp: > > #0 0x100007b0 in main () > (gdb) show language > show language > The current source language is "auto; currently asm". > This binary has no debug info (by test design), so we should just make the test do "set language c" (with a comment). > compile-ops.exp: > > Breakpoint 1, 0x10000724 in func (param=268503652, > optimized_out=)^M > (gdb) compile code -- ;^M > No compiler support for this language.^M > > show language > The current source language is "auto; currently asm". This one looks like a gdb bug? AFAICS, the test generates debug info, and gdb should have figured out the language is c. At least, from skimming the test's .exp, I see: compile_unit { {name file1.txt} {language @DW_LANG_C} ^^^^^^^^^^^^^^^^^^^ {low_pc func_start addr} {high_pc func_end addr} } { global program BTW, it'd be nice if the "No compiler support for this language" error told us which language is "this"... Thanks, Pedro Alves