From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 108830 invoked by alias); 19 Aug 2015 13:15:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 108817 invoked by uid 89); 19 Aug 2015 13:15:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 19 Aug 2015 13:15:40 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id B7B8F4C08C; Wed, 19 Aug 2015 13:15:39 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t7JDFcma024324; Wed, 19 Aug 2015 09:15:38 -0400 Message-ID: <55D48179.2030000@redhat.com> Date: Wed, 19 Aug 2015 13:15:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Luis Machado , gdb-patches@sourceware.org Subject: Re: [PATCH] Guard compile tests from running when unsupported + harden feature support check References: <1439988825-19754-1-git-send-email-lgustavo@codesourcery.com> In-Reply-To: <1439988825-19754-1-git-send-email-lgustavo@codesourcery.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-08/txt/msg00511.txt.bz2 On 08/19/2015 01:53 PM, Luis Machado wrote: > + if {[skip_compile_feature_tests]} { > + untested "compile command not supported (could not find libcc1 shared library?)" > + return -1 > + } > + > # gnu_ifunc (10): error: too many arguments to function 'gnu_ifunc' > gdb_test_no_output "compile code resultvar = gnu_ifunc_alias (10);" > This one's OK. > diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp > index 56cde7a..fcf9cac 100644 > --- a/gdb/testsuite/lib/gdb.exp > +++ b/gdb/testsuite/lib/gdb.exp > @@ -3005,6 +3005,9 @@ proc skip_compile_feature_tests {} { > -re "Command not supported on this host\\..*\r\n$gdb_prompt $" { > set result 1 > } > + -re "No compiler support for this language\\.\r\n$gdb_prompt $" { > + set result 1 > + } This one I'm not so sure. I'd suspect that that could happen when e.g., gdb connects to gdbserver and finds the program stopped at the entry point, and then the current language ends up set to asm instead of C. But then that would be a test bug and it would be wrong to skip further testing. But please don't make us guess; please expand on when do you see this. Thanks, Pedro Alves