From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28782 invoked by alias); 18 Aug 2015 15:21:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28770 invoked by uid 89); 18 Aug 2015 15:21:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pd0-f173.google.com Received: from mail-pd0-f173.google.com (HELO mail-pd0-f173.google.com) (209.85.192.173) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 18 Aug 2015 15:21:37 +0000 Received: by pdbmi9 with SMTP id mi9so28661390pdb.3 for ; Tue, 18 Aug 2015 08:21:35 -0700 (PDT) X-Received: by 10.70.36.138 with SMTP id q10mr14381609pdj.32.1439911295564; Tue, 18 Aug 2015 08:21:35 -0700 (PDT) Received: from [127.0.0.1] (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id y9sm6927096pas.42.2015.08.18.08.21.33 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 18 Aug 2015 08:21:34 -0700 (PDT) Message-ID: <55D34D7A.4020909@gmail.com> Date: Tue, 18 Aug 2015 15:21:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Joel Brobecker CC: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [PATCH 2/7] New regs_info for aarch32 References: <1438355801-25798-1-git-send-email-yao.qi@linaro.org> <1438355801-25798-3-git-send-email-yao.qi@linaro.org> <55BF7383.5030304@redhat.com> <55BF980F.5010306@gmail.com> <55BFA0AD.5000408@redhat.com> <86614ve5z5.fsf@gmail.com> <20150811194012.GA19956@adacore.com> In-Reply-To: <20150811194012.GA19956@adacore.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2015-08/txt/msg00469.txt.bz2 On 11/08/15 20:40, Joel Brobecker wrote: > This patch is causing a GDBserver build failure on some versions > of GNU/Linux (the version we support is fairly old), but also on > relatively recent versions of Android as well. > > The problem is that NT_ARM_VFP is not always defined. I tried > the attached patch, which I was a bit dubious about, but seems > to work ("info float" does not error out, and print a series of zeros), > but I'm not sure whether I'm exercising the code at all. The other > alternative I was thinking of was perhaps to just #ifndef out > the entry in aarch32_regsets that needs NT_ARM_VFP. It might be > cleaner, but I haven't tried it. If kernel doesn't support NT_ARM_VFP, GDBserver (linux-low.c:regsets_fetch_inferior_registers) can disable this regset_info. On the other hand, if kernel is too old to support PTRACE_GETREGSET, aarch32_regsets won't be used at all. > > gdb/gdbserver/ChangeLog: > > * linux-aarch32-low.c (NT_ARM_VFP): Define if not already defined. > Patch looks right to me. -- Yao (齐尧)