Re: [PATCH v4 00/18] All-stop on top of non-stop

Luis Machado
2015-08-12T20:31:11Z

On 08/12/2015 05:26 PM, Joel Brobecker wrote:
>>> This uncovered what I think is a latent bug in the "how-did-we-never-
>>> see-this-before" category.
>>
>> Wow! Indeed. Many thanks for tracking this down and fixing it.
>>
>> A couple minor comments below, but this looks good to me.
>
> And thanks for the super-quick review.
>
> Attached is what I ended up pushing. It should address all your
> comments, and also add a comment in the testcase script to explain
> its purpose. If this isn't sufficient for Luis and Sergio, then
> we can try to find other solutions (including renaming the testcase,
> if necessary).

My idea of a testcase comment is at the beginning of the testcase file,
explaining what the test does and why it does it. I'd mention the amd64
example as well, since it is part of why the test was created in the
first place.

That should give others enough background to pursue an investigation
about why this potentially fails for them.

My 2 cents anyway.