From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 72844 invoked by alias); 12 Aug 2015 19:48:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 72832 invoked by uid 89); 12 Aug 2015 19:48:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg20.ericsson.net Received: from usevmg20.ericsson.net (HELO usevmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 12 Aug 2015 19:48:33 +0000 Received: from EUSAAHC007.ericsson.se (Unknown_Domain [147.117.188.93]) by usevmg20.ericsson.net (Symantec Mail Security) with SMTP id 2F.BA.17751.E064BC55; Wed, 12 Aug 2015 15:11:43 +0200 (CEST) Received: from [142.133.110.144] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.95) with Microsoft SMTP Server id 14.3.210.2; Wed, 12 Aug 2015 15:48:30 -0400 Message-ID: <55CBA30E.9090004@ericsson.com> Date: Wed, 12 Aug 2015 19:48:00 -0000 From: Simon Marchi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Pedro Alves , Subject: Re: [PATCH 1/7] Merge async and sync code paths some more References: <1439398917-22761-1-git-send-email-palves@redhat.com> <1439398917-22761-2-git-send-email-palves@redhat.com> In-Reply-To: <1439398917-22761-2-git-send-email-palves@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-08/txt/msg00318.txt.bz2 On 15-08-12 01:01 PM, Pedro Alves wrote: > diff --git a/gdb/mi/mi-interp.c b/gdb/mi/mi-interp.c > index 99ce385..bdd8e21 100644 > --- a/gdb/mi/mi-interp.c > +++ b/gdb/mi/mi-interp.c > @@ -309,16 +309,8 @@ mi_execute_command_wrapper (const char *cmd) > static void > mi_on_sync_execution_done (void) > { > - /* MI generally prints a prompt after a command, indicating it's > - ready for further input. However, due to an historical wart, if > - MI async, and a (CLI) synchronous command was issued, then we > - will print the prompt right after printing "^running", even if we > - cannot actually accept any input until the target stops. See > - mi_on_resume. However, if the target is async but MI is sync, > - then we need to output the MI prompt now, to replicate gdb's > - behavior when neither the target nor MI are async. (Note this > - observer is only called by the asynchronous target event handling > - code.) */ > + /* If we MI is sync, then output the MI prompt now, indicating we're > + ready for further input. */ "If we MI is sync"