From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-125197-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 118854 invoked by alias); 12 Aug 2015 18:32:49 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 118840 invoked by uid 89); 12 Aug 2015 18:32:48 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 12 Aug 2015 18:32:48 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (Postfix) with ESMTPS id 0619619CF99	for <gdb-patches@sourceware.org>; Wed, 12 Aug 2015 18:32:46 +0000 (UTC)
Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t7CIWkEv030007	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO)	for <gdb-patches@sourceware.org>; Wed, 12 Aug 2015 14:32:46 -0400
Subject: Re: [PATCH] Initialize `location' in gdbpy_decode_line
References: <1439401110-12694-1-git-send-email-keiths@redhat.com> <CADPb22S-Wrhw9aEVR9LhmVJ7rPYi0GgDxKCSW8qgGUNT12jU-A@mail.gmail.com>
To: gdb-patches <gdb-patches@sourceware.org>
From: Keith Seitz <keiths@redhat.com>
Message-ID: <55CB914D.3020802@redhat.com>
Date: Wed, 12 Aug 2015 18:32:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0
MIME-Version: 1.0
In-Reply-To: <CADPb22S-Wrhw9aEVR9LhmVJ7rPYi0GgDxKCSW8qgGUNT12jU-A@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2015-08/txt/msg00312.txt.bz2

On 08/12/2015 10:45 AM, Doug Evans wrote:
> On Wed, Aug 12, 2015 at 10:38 AM, Keith Seitz <keiths@redhat.com> wrote:
>> BuildBot flagged an uninitialized variable coming from one of the patches
>> in my recently committed locations/explicit patchset.
>>
>> The following patch fixes this.
>>
>> Ok?
>>
>> gdb/ChangeLog
>>
>>         * python/python.c (gdbpy_decode_line): Initialize `location' to NULL
>>         and only call decode_line_1 when it is non-NULL.
>>
> 
> LGTM
> 

I've pushed this. Thank you, Doug.

Keith