From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15357 invoked by alias); 12 Aug 2015 15:31:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15343 invoked by uid 89); 12 Aug 2015 15:31:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 12 Aug 2015 15:31:47 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 493ED8F243; Wed, 12 Aug 2015 15:31:46 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t7CFVhdJ010792; Wed, 12 Aug 2015 11:31:43 -0400 Message-ID: <55CB66DE.5040203@redhat.com> Date: Wed, 12 Aug 2015 15:31:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Gary Benson CC: Joel Brobecker , Doug Evans , Jan Kratochvil , gdb-patches , Sandra Loosemore , =?windows-1252?Q?Andr=E9_P=F6nitz?= , Paul Koning Subject: Re: [PATCH 0/2] Better handling of slow remote transfers References: <55CB1B8D.6010501@redhat.com> <20150812103831.GA12792@blade.nx> <55CB2DF8.2050506@redhat.com> <20150812123254.GA14726@blade.nx> <55CB4150.6090807@redhat.com> <20150812130248.GA15429@blade.nx> <55CB4B74.3070204@redhat.com> <20150812133825.GA25961@blade.nx> <55CB5119.9070504@redhat.com> <55CB5BDA.3020904@redhat.com> <20150812150841.GA20824@blade.nx> In-Reply-To: <20150812150841.GA20824@blade.nx> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-08/txt/msg00291.txt.bz2 On 08/12/2015 04:08 PM, Gary Benson wrote: > Pedro Alves wrote: >> On 08/12/2015 02:58 PM, Pedro Alves wrote: >>> GDB will usually cap the transfers to before they get to the >>> lower layers. E.g., look for 4096 in memory_xfer_partial, >>> target_read_alloc_1 and target_fileio_read_alloc_1. >>> >>> As this request is coming from the BFD side, we should probably >>> make remote_hostio_pread also cap the size of the vFile:pread >>> request. A reasonable number like a few KBs should not >>> introduce any noticeable slow down. >> >> But wait, I'm now confused -- isn't this a red herring? Since >> gdbserver is already limiting transfers to PBUFSIZE, this change >> should have no practical effect, right? >> >> How can BFD's large remote_hostio_pread result in large vFile:pread: >> packet responses then? > > I think gdbserver is returning multiple packets but something in GDB > (getpkt_or_notif_sane_1?) is concatenating them together somehow. No, getpkt_or_notif_sane_1 will return as soon as it has a single packet, which should then be bubbling up the layers and reaching gdb_bfd_iovec_fileio_pread. Something else is going on. Either the QUIT is being lost/eaten, or ... hmm ... maybe the SIGINT handler is set to remote.c:async_handle_remote_sigint when the ctrl-c is typed, which means the ctrl-c doesn't actually set_quit_flag()? Thanks, Pedro Alves