From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 55185 invoked by alias); 12 Aug 2015 10:30:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 55159 invoked by uid 89); 12 Aug 2015 10:30:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 12 Aug 2015 10:30:27 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id DF0AEFC0FD; Wed, 12 Aug 2015 10:30:25 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t7CAUOTs025335; Wed, 12 Aug 2015 06:30:24 -0400 Message-ID: <55CB203F.7060002@redhat.com> Date: Wed, 12 Aug 2015 10:30:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Matthew Fortune , "gdb-patches@sourceware.org" CC: Joseph Myers Subject: Re: [PATCH, MIPS] Support shared library debug with MIPS PIE (gdb) References: <6D39441BF12EF246A7ABCE6654B02353211760FA@LEMAIL01.le.imgtec.org> <6D39441BF12EF246A7ABCE6654B02353211AFAAB@LEMAIL01.le.imgtec.org> In-Reply-To: <6D39441BF12EF246A7ABCE6654B02353211AFAAB@LEMAIL01.le.imgtec.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-08/txt/msg00269.txt.bz2 On 06/26/2015 01:45 PM, Matthew Fortune wrote: > Joseph Myers writes: >> On Tue, 23 Jun 2015, Matthew Fortune wrote: >> >>> Please note that the new DT_MIPS_RLD_MAP2 support will not be enabled >>> unless the host's elf.h header has the new tag defined in it. For >>> cross compiled GDB this may mean hacking the solib-svr4.c file to >>> define the macro until such time as distributions update glibc. >> >> That doesn't make any sense to me. Hosts (e.g. MinGW) may not have >> elf.h at all. GDB should get these definitions from the #include >> "elf/mips.h" >> already in solib-svr4.c (i.e. from toplevel's include/elf/mips.h). And >> so there should be no #ifdefs there. Thanks Joseph. > Updated version below to match the name of the new tag as committed to > binutils and removed the #ifdefs from solib-svr4.c. > > binutils commit: a5499fa Add support for DT_MIPS_RLD_MAP_REL. > > OK to commit? > OK. Thanks, Pedro Alves