From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 129332 invoked by alias); 12 Aug 2015 09:30:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 129322 invoked by uid 89); 12 Aug 2015 09:30:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 12 Aug 2015 09:30:42 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 8DBAA96C4; Wed, 12 Aug 2015 09:30:41 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t7C9Udns006189; Wed, 12 Aug 2015 05:30:40 -0400 Message-ID: <55CB123F.70603@redhat.com> Date: Wed, 12 Aug 2015 09:30:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Doug Evans , Joel Brobecker CC: Simon Marchi , gdb-patches , Yao Qi Subject: Re: [PATCH] Remove symlinks created in argv0-symlink.exp and general cleanup References: <1438287227-11303-1-git-send-email-simon.marchi@ericsson.com> <55BF7962.3060106@redhat.com> <55BF85BC.8040102@ericsson.com> <55BF9811.50202@redhat.com> <20150804172110.GI4777@adacore.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-08/txt/msg00264.txt.bz2 On 08/11/2015 06:35 PM, Doug Evans wrote: > On Tue, Aug 4, 2015 at 10:21 AM, Joel Brobecker wrote: >>> Personally, I'd vote for making in-tree builds, or at least testing, >>> officially unsupported. I think gcc already does so... >> >> We should seriously discuss this, one day, as we keep having to >> spend time fixing issues specific to that mode. > > I don't have a strong opinion on making in-tree testing unsupported, > but I do have a strong opinion on another thing that can make the > in-tree testing issue moot. > > Let's remove all of testsuite/*/Makefile.in, they're always > out of date anyway (i.e., no one updates gdb.foo/Makefile.in to > remove binaries added by new tests), > and except for "make clean" aren't really used for anything. > The "make clean" in testsuite/Makefile.in can just "rm -rf foo bar ..." > [where "foo bar ..." are *not* the gdb.* testsuite dirs, but rather > the outputs,etc. directories of check-parallel] > IOW, testing would create the needed directories on the fly, > even in serial mode, > and to simplify "make clean" they'd always be put in a fixed > subdir of testsuite (just like check-parallel does now). *nod* I believe Yao had patches a while ago that went in this direction. Don't know what happened to them. [+Yao]. > > As for whether to always have one directory per test > (in serial and parallel modes), that *could* be treated as a separate > issue, but if it reduces complexity by doing the same thing > for serial and parallel then great. I believe this would be worthwhile. Taking this a step further, if we always ran in parallel mode (the equivalent of make check -j1 FORCE_PARALLEL=1), then variable bleeding between tests would no longer be an issue, as then we'd invoke a dejagnu/runtest per test. That would mean making GNU Make a requirement for testing (which IMO, should be OK). > [And while in-tree testing could still be unsupported, > I think(!) the current issue with it would be fixed.] Thanks, Pedro Alves