From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 86311 invoked by alias); 10 Aug 2015 18:05:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 86297 invoked by uid 89); 10 Aug 2015 18:05:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 10 Aug 2015 18:05:50 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 9CFB38E505; Mon, 10 Aug 2015 18:05:49 +0000 (UTC) Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t7AI5lUf004804 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 10 Aug 2015 14:05:49 -0400 Subject: Re: [PATCH v6 2/9] Explicit locations: introduce new struct event_location-based API To: Doug Evans References: <20150805232802.21646.88440.stgit@valrhona.uglyboxes.com> <20150805232913.21646.96976.stgit@valrhona.uglyboxes.com> Cc: gdb-patches@sourceware.org From: Keith Seitz X-Enigmail-Draft-Status: N1110 Message-ID: <55C8E7FB.3030106@redhat.com> Date: Mon, 10 Aug 2015 18:05:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2015-08/txt/msg00222.txt.bz2 On 08/10/2015 10:33 AM, Doug Evans wrote: > Later (not now, let's get this sucker checked in, unless of course > you really want to), let's make event_location_to_string take a > const struct event_location *, and make the cached copy > "mutable in the c++ sense". Bah. You got me on that one. This was used as part of the pending-location hack ("append extra_string to the location") in create_breakpoint: if (extra_string != NULL) { char *new = xstrprintf ("%s %s", event_location_to_string_const (location), extra_string); set_event_location_string (b->location, new); xfree (new); } ... which was removed in this revision, and I forgot to check if it was being used at all anymore. Answer: No, it is not used anymore. I could just remove it entirely. Which is what I've done in my local copy. [Do you want me to repost this?] Thanks! Keith