From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 89070 invoked by alias); 4 Aug 2015 18:41:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 89060 invoked by uid 89); 4 Aug 2015 18:41:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg20.ericsson.net Received: from usevmg20.ericsson.net (HELO usevmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 04 Aug 2015 18:41:22 +0000 Received: from EUSAAHC007.ericsson.se (Unknown_Domain [147.117.188.93]) by usevmg20.ericsson.net (Symantec Mail Security) with SMTP id 0B.75.12958.ABAA0C55; Tue, 4 Aug 2015 14:06:18 +0200 (CEST) Received: from [142.133.110.95] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.95) with Microsoft SMTP Server id 14.3.210.2; Tue, 4 Aug 2015 14:41:20 -0400 Message-ID: <55C1074F.8060300@ericsson.com> Date: Tue, 04 Aug 2015 18:41:00 -0000 From: Antoine Tremblay User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Joel Brobecker CC: Subject: Re: [PATCH] Fix instruction skipping when using software single step in gdbserver. References: <1438353367-24936-1-git-send-email-antoine.tremblay@ericsson.com> <20150804171823.GH4777@adacore.com> In-Reply-To: <20150804171823.GH4777@adacore.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-08/txt/msg00098.txt.bz2 On 08/04/2015 01:18 PM, Joel Brobecker wrote: > Just a small trivial comment while scanning the patch... > >> --- a/gdb/gdbserver/mem-break.c >> +++ b/gdb/gdbserver/mem-break.c >> @@ -1660,6 +1660,21 @@ hardware_breakpoint_inserted_here (CORE_ADDR addr) >> return 0; >> } >> >> +int >> +reinsert_breakpoint_inserted_here (CORE_ADDR addr) > > Can you add the standard bread crumb comment that indicates that > the function is in fact documented, and where that documentation > is? Eg: > > /* See mem-break.h. */ > > Thank you! :) > Right, I'll add it now :) Thanks,