From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124444 invoked by alias); 3 Aug 2015 16:34:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 124338 invoked by uid 89); 3 Aug 2015 16:34:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pd0-f173.google.com Received: from mail-pd0-f173.google.com (HELO mail-pd0-f173.google.com) (209.85.192.173) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 03 Aug 2015 16:34:39 +0000 Received: by pdbbo16 with SMTP id bo16so18471262pdb.1 for ; Mon, 03 Aug 2015 09:34:37 -0700 (PDT) X-Received: by 10.70.130.177 with SMTP id of17mr37842732pdb.108.1438619677927; Mon, 03 Aug 2015 09:34:37 -0700 (PDT) Received: from [127.0.0.1] (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id u16sm18007547pdl.71.2015.08.03.09.34.33 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Aug 2015 09:34:37 -0700 (PDT) Message-ID: <55BF980F.5010306@gmail.com> Date: Mon, 03 Aug 2015 16:34:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [PATCH 2/7] New regs_info for aarch32 References: <1438355801-25798-1-git-send-email-yao.qi@linaro.org> <1438355801-25798-3-git-send-email-yao.qi@linaro.org> <55BF7383.5030304@redhat.com> In-Reply-To: <55BF7383.5030304@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2015-08/txt/msg00031.txt.bz2 On 03/08/15 14:58, Pedro Alves wrote: > Why weren't these moved as well? At first, > >> >- init_registers_arm_with_vfpv2 (); >> >- init_registers_arm_with_vfpv3 (); >> >- init_registers_arm_with_neon (); >> >+ >> >+ initialize_low_arch_aarch32 (); > I thought that this was because aarch64 doesn't > do the old iwmmxt, but then in the following patch you > have this anyway: Yes, aarch64 doesn't support iwmmxt. > >> > void >> > initialize_low_arch_aarch32 (void) >> > { >> >+#ifndef __aarch64__ >> > init_registers_arm_with_vfpv2 (); >> > init_registers_arm_with_vfpv3 (); >> >+#endif >> > init_registers_arm_with_neon (); >> > > So I don't understand when/where to initialize arm32 > descriptions going forward. Sorry, I am not sure I understand your question. initialize_low_arch_aarch32 is called from linux-arm-low.c and linux-aarch64-low.c for arm and aarch64 target respectively. For aarch64, we initialize arm_with_neon while for arm, we initialize arm_with_vfpv2 and arm_with_vfpv3 additionally. -- Yao (齐尧)