From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34397 invoked by alias); 3 Aug 2015 14:23:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 34380 invoked by uid 89); 3 Aug 2015 14:23:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 03 Aug 2015 14:23:33 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 297F6A49FE; Mon, 3 Aug 2015 14:23:32 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t73ENUvx015017; Mon, 3 Aug 2015 10:23:31 -0400 Message-ID: <55BF7962.3060106@redhat.com> Date: Mon, 03 Aug 2015 14:23:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH] Remove symlinks created in argv0-symlink.exp and general cleanup References: <1438287227-11303-1-git-send-email-simon.marchi@ericsson.com> In-Reply-To: <1438287227-11303-1-git-send-email-simon.marchi@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-08/txt/msg00023.txt.bz2 On 07/30/2015 09:13 PM, Simon Marchi wrote: > When running argv0-symlink.exp, symlinks are left in the test output > directory. One of them is a recursive symlink. This causes the same tests > to be found multiple times and disturbs subsequent test runs. > > To witness it simply, just run > > $ make check RUNTESTFLAGS="argv0-symlink.exp" > > twice in a row. The second run will find and run argv0-symlink.exp > multiple times because of the recursive symlink left by the first run. Note > that this only happens when building in tree. The simple fix is to > remove the links when we are done. > > At the same time, I did a general cleanup of the test: > > - Add and use a create_link proc. > - Bail out early if target does not support argv[0]. What's the rationale for that? It seems that'd skip the tests that ensure that "info inferiors" shows the $filelink; those aren't currently guarded by $has_argv. AFAICS, that was done on purpose. See: git show 673dc4a0 git show 673dc4a0:gdb/testsuite/gdb.base/argv0-symlink.exp > - Of course, remove created symlinks before returning. I think you should leave them, actually. That's a general direction we've been following -- leaving build/test artifacts in place in case the test fails and we need to debug what happened. So instead what we do is remove any leftover from a previous run that could interfere, when we start a new run. (I think the patch is already doing that too.) Thanks, Pedro Alves