Re: [PATCH] Replace the block_found global with explicit data-flow

Doug Evans
2015-07-22T14:15:22Z

On Tue, Jul 21, 2015 at 11:49 AM, Pierre-Marie de Rodat
<derodat@adacore.com> wrote:
> On 07/21/2015 06:36 PM, Pierre-Marie de Rodat wrote:
>>
>> As Pedro suggested on gdb-patches@ (see
>> <https://sourceware.org/ml/gdb-patches/2015-05/msg00714.html>), this
>> change makes symbol lookup functions return a structure that includes
>> both the symbol found and the block in which it was found. This makes
>> it possible to get rid of the block_found global variable and thus makes
>> block hunting explicit.
>>
>> I saw no regression on x86_64-linux. Ok for trunk?
>
>
> Ahem… here’s the patch… :-/ One day I will take some time to configure git
> send-email...

Hi.

Thanks. Others may approve this, but as I've had my hand in all of this code
more than anyone recently I'd like to review it too.
I'll have time this weekend, fingers crossed.