Re: [PATCH] Replace the block_found global with explicit data-flow

Pedro Alves
2015-08-02T18:17:24Z

On 08/01/2015 10:35 AM, Pierre-Marie de Rodat wrote:
> On 08/01/2015 11:08 AM, Pierre-Marie de Rodat wrote:
>> On 08/01/2015 10:57 AM, Pierre-Marie de Rodat wrote:
>>> This is pushed, now.
>>
>> Sergio's buildbot detected a compilation error:
>>
>> ../../binutils-gdb/gdb/ft32-tdep.c: In function 'ft32_skip_prologue':
>> ../../binutils-gdb/gdb/ft32-tdep.c:253:8: error: incompatible types when
>> assigning to type 'struct symbol *' from type 'struct block_symbol'
>> sym = lookup_symbol (func_name, NULL, VAR_DOMAIN, NULL);
>>
>> Strange, I don't have this problem locally. Investigating how the
>> buildbot's build is different (mhm… probably this --enable-targets=all).
>
> Indeed, that was the problem. I've updated my scripts to always build
> with this option, I've fixed the obvious errors (patch attached) and I
> saw no regression on x86_64-linux.
>
> Ok to push?
>

Thanks, this is OK. I went ahead and pushed this for you, to avoid
keeping the tree broken for too long.

--
Pedro Alves