Re: [PATCH] Replace the block_found global with explicit data-flow

Pierre-Marie de Rodat
2015-08-01T19:36:04Z

On 08/01/2015 08:24 PM, Luis Machado wrote:
>> Understood: here's an updated patch introducing a temporary to do this.
>> Thank you!
>
> Thanks!
>
> I think you forgot to fix the other occurrences though.

Arg, sorry: I thought you were suggesting this to get rid of the weird
indentation behavior (hence my fix on the first occurence only).

At this point I wonder what to do: this patch indeed introduces some of
“foo(..).barâ€ constructs, but my previous one introduced a _lot_ more.
So my feeling is that the code will get bigger and less readable...
that's my personal taste anyway. ;-) That being said, I'm completely
open to settling on this style anyway, as long as we are aware of the
consequences.