Re: [PATCH] Replace the block_found global with explicit data-flow

Iain Buclaw
2015-07-22T15:48:39Z

On 22 July 2015 at 16:15, Doug Evans <xdje42@gmail.com> wrote:
> On Tue, Jul 21, 2015 at 11:49 AM, Pierre-Marie de Rodat
> <derodat@adacore.com> wrote:
>> On 07/21/2015 06:36 PM, Pierre-Marie de Rodat wrote:
>>>
>>> As Pedro suggested on gdb-patches@ (see
>>> <https://sourceware.org/ml/gdb-patches/2015-05/msg00714.html>), this
>>> change makes symbol lookup functions return a structure that includes
>>> both the symbol found and the block in which it was found. This makes
>>> it possible to get rid of the block_found global variable and thus makes
>>> block hunting explicit.
>>>
>>> I saw no regression on x86_64-linux. Ok for trunk?
>>
>>
>> Ahem… here’s the patch… :-/ One day I will take some time to configure git
>> send-email...
>
> Hi.
>
> Thanks. Others may approve this, but as I've had my hand in all of this code
> more than anyone recently I'd like to review it too.
> I'll have time this weekend, fingers crossed.

I'm also in the midst of making large changes around this area with
the language_d codebase. Depending on what gets in first, one of us
will need to rebase our current patches. ;-)

Iain