From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 46305 invoked by alias); 2 Aug 2015 18:17:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 46293 invoked by uid 89); 2 Aug 2015 18:17:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sun, 02 Aug 2015 18:17:23 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 541B58F009; Sun, 2 Aug 2015 18:17:21 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t72IHJXc022088; Sun, 2 Aug 2015 14:17:20 -0400 Message-ID: <55BE5EAE.7000602@redhat.com> Date: Sun, 02 Aug 2015 18:17:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Pierre-Marie de Rodat , Doug Evans CC: GDB Patches Subject: Re: [PATCH] Replace the block_found global with explicit data-flow References: <55AE7520.1010307@adacore.com> <55AE943F.3000009@adacore.com> <55BA299D.7040407@adacore.com> <55BC89E6.9040705@adacore.com> <55BC8CA9.3070505@adacore.com> <55BC92D8.8070407@adacore.com> In-Reply-To: <55BC92D8.8070407@adacore.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2015-08/txt/msg00009.txt.bz2 On 08/01/2015 10:35 AM, Pierre-Marie de Rodat wrote: > On 08/01/2015 11:08 AM, Pierre-Marie de Rodat wrote: >> On 08/01/2015 10:57 AM, Pierre-Marie de Rodat wrote: >>> This is pushed, now. >> >> Sergio's buildbot detected a compilation error: >> >> ../../binutils-gdb/gdb/ft32-tdep.c: In function 'ft32_skip_prologue': >> ../../binutils-gdb/gdb/ft32-tdep.c:253:8: error: incompatible types when >> assigning to type 'struct symbol *' from type 'struct block_symbol' >> sym = lookup_symbol (func_name, NULL, VAR_DOMAIN, NULL); >> >> Strange, I don't have this problem locally. Investigating how the >> buildbot's build is different (mhm… probably this --enable-targets=all). > > Indeed, that was the problem. I've updated my scripts to always build > with this option, I've fixed the obvious errors (patch attached) and I > saw no regression on x86_64-linux. > > Ok to push? > Thanks, this is OK. I went ahead and pushed this for you, to avoid keeping the tree broken for too long. -- Pedro Alves