From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23490 invoked by alias); 1 Aug 2015 23:19:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23477 invoked by uid 89); 1 Aug 2015 23:18:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 01 Aug 2015 23:18:58 +0000 Received: from svr-orw-fem-05.mgc.mentorg.com ([147.34.97.43]) by relay1.mentorg.com with esmtp id 1ZLg3K-0007DA-PO from Luis_Gustavo@mentor.com ; Sat, 01 Aug 2015 16:18:54 -0700 Received: from [172.30.12.45] (147.34.91.1) by svr-orw-fem-05.mgc.mentorg.com (147.34.97.43) with Microsoft SMTP Server id 14.3.224.2; Sat, 1 Aug 2015 16:18:53 -0700 Message-ID: <55BD53DA.9010805@codesourcery.com> Date: Sat, 01 Aug 2015 23:19:00 -0000 From: Luis Machado Reply-To: Luis Machado User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Pierre-Marie de Rodat , Doug Evans CC: GDB Patches , Pedro Alves Subject: Re: [PATCH] Replace the block_found global with explicit data-flow References: <55AE7520.1010307@adacore.com> <55AE943F.3000009@adacore.com> <55BA299D.7040407@adacore.com> <55BC89E6.9040705@adacore.com> <55BC8CA9.3070505@adacore.com> <55BC92D8.8070407@adacore.com> <55BCEDF1.2070806@codesourcery.com> <55BCF2E7.9000800@adacore.com> <55BD0EDD.9040903@codesourcery.com> <55BD1F9E.6000603@adacore.com> In-Reply-To: <55BD1F9E.6000603@adacore.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2015-08/txt/msg00007.txt.bz2 On 08/01/2015 04:35 PM, Pierre-Marie de Rodat wrote: > On 08/01/2015 08:24 PM, Luis Machado wrote: >>> Understood: here's an updated patch introducing a temporary to do this. >>> Thank you! >> >> Thanks! >> >> I think you forgot to fix the other occurrences though. > > Arg, sorry: I thought you were suggesting this to get rid of the weird > indentation behavior (hence my fix on the first occurence only). > > At this point I wonder what to do: this patch indeed introduces some of > “foo(..).bar” constructs, but my previous one introduced a _lot_ more. > So my feeling is that the code will get bigger and less readable... > that's my personal taste anyway. ;-) That being said, I'm completely > open to settling on this style anyway, as long as we are aware of the > consequences. > Indeed. I didn't review the original patch, so only this one caught my attention. I agree it is not worth fixing this if a bunch of other occurrences were added. Maybe a new function should've been introduced to avoid having to keep accessing that field, which would be both shorter and cleaner. Then again, it is probably only costmetic. The move to C++ will potentially introduce lots more occurrences in the future. :-)