From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-124890-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 24212 invoked by alias); 1 Aug 2015 18:24:38 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 24203 invoked by uid 89); 1 Aug 2015 18:24:38 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.2
X-HELO: relay1.mentorg.com
Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 01 Aug 2015 18:24:37 +0000
Received: from svr-orw-fem-06.mgc.mentorg.com ([147.34.97.120])	by relay1.mentorg.com with esmtp 	id 1ZLbST-0002hO-0D from Luis_Gustavo@mentor.com ; Sat, 01 Aug 2015 11:24:33 -0700
Received: from [172.30.12.45] (147.34.91.1) by SVR-ORW-FEM-06.mgc.mentorg.com (147.34.97.120) with Microsoft SMTP Server id 14.3.224.2; Sat, 1 Aug 2015 11:24:32 -0700
Message-ID: <55BD0EDD.9040903@codesourcery.com>
Date: Sat, 01 Aug 2015 18:24:00 -0000
From: Luis Machado <lgustavo@codesourcery.com>
Reply-To: Luis Machado <lgustavo@codesourcery.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0
MIME-Version: 1.0
To: Pierre-Marie de Rodat <derodat@adacore.com>, Doug Evans <xdje42@gmail.com>
CC: GDB Patches <gdb-patches@sourceware.org>, Pedro Alves <palves@redhat.com>
Subject: Re: [PATCH] Replace the block_found global with explicit data-flow
References: <55AE7520.1010307@adacore.com> <55AE943F.3000009@adacore.com> <m3lhe4yls4.fsf@sspiff.org> <55BA299D.7040407@adacore.com> <55BC89E6.9040705@adacore.com> <55BC8CA9.3070505@adacore.com> <55BC92D8.8070407@adacore.com> <55BCEDF1.2070806@codesourcery.com> <55BCF2E7.9000800@adacore.com>
In-Reply-To: <55BCF2E7.9000800@adacore.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2015-08/txt/msg00005.txt.bz2

On 08/01/2015 01:25 PM, Pierre-Marie de Rodat wrote:
> On 08/01/2015 06:04 PM, Luis Machado wrote:
>>> +    sym = lookup_symbol (MDEBUG_EFI_SYMBOL_NAME, b, LABEL_DOMAIN,
>>> +                 0).symbol;
>>>       }
>>
>> It is probably a matter of personal taste, but i find it easier and
>> cleaner to get the result of lookup_symbol (...) assigned to a variable
>> and then have the code access its 'symbol' field as opposed to chaining
>> things like the above.
>>
>> The current codebase doesn't show many occurrences like the above.
>
> Understood: here's an updated patch introducing a temporary to do this.
> Thank you!
>

Thanks!

I think you forgot to fix the other occurrences though.