From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 47453 invoked by alias); 30 Jul 2015 11:41:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 47436 invoked by uid 89); 30 Jul 2015 11:41:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (146.101.78.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 30 Jul 2015 11:41:34 +0000 Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-15-Xoj81shPSoSSUVw9NMWI2g-1; Thu, 30 Jul 2015 12:41:29 +0100 Received: from [10.2.207.36] ([10.1.2.79]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Thu, 30 Jul 2015 12:41:29 +0100 Message-ID: <55BA0D69.60701@arm.com> Date: Thu, 30 Jul 2015 11:41:00 -0000 From: Pierre Langlois User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Yao Qi CC: pierre.langlois@arm.com, "gdb-patches@sourceware.org" Subject: Re: [PATCH] [AArch64] Rename boolean arguments in decoding functions References: <1438162390-30381-1-git-send-email-pierre.langlois@arm.com> <864mklga6z.fsf@gmail.com> In-Reply-To: <864mklga6z.fsf@gmail.com> X-MC-Unique: Xoj81shPSoSSUVw9NMWI2g-1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg00898.txt.bz2 On 30/07/15 12:24, Yao Qi wrote: > Pierre Langlois writes: >=20 >> * aarch64-tdep.c (decode_b): Rename link argument to is_bl. >> Change its type to int *. >> (decode_br): Rename link argument to is_blr. Change its type to >> int *. >> (decode_cb): Rename op argument to is_cbnz. Change its type to >> int *. >> (decode_tb): Rename op argument to is_tbnz. Change its type to >> int *. Set is_tbnz to either 1 or 0. >> (aarch64_analyze_prologue): Change type of is_link to int. Add >> new variables is_cbnz and is_tbnz. Adjust call to >> aarch64_decode_cb and aarch64_decode_tb. >=20 > Patch looks good to me. >=20 Thanks Yao, I've pushed this in. Thanks, Pierre