From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5489 invoked by alias); 29 Jul 2015 21:59:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5476 invoked by uid 89); 29 Jul 2015 21:59:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 29 Jul 2015 21:59:50 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id A1DED19CF53; Wed, 29 Jul 2015 21:59:49 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t6TLxlWh016381; Wed, 29 Jul 2015 17:59:48 -0400 Message-ID: <55B94CD3.5080705@redhat.com> Date: Wed, 29 Jul 2015 21:59:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Simon Marchi , gdb-patches@sourceware.org CC: Brendan Kirby , Sergio Durigan Junior Subject: Re: [PATCH obv/pushed] MIPS ptrace build fixes References: <1438204741-24808-1-git-send-email-simon.marchi@ericsson.com> <55B94502.4080000@ericsson.com> In-Reply-To: <55B94502.4080000@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-07/txt/msg00888.txt.bz2 On 07/29/2015 10:26 PM, Simon Marchi wrote: > On 15-07-29 05:19 PM, Simon Marchi wrote: >> FYI, I am pushing this as obvious. >> >> Since Pedro's ptrace cleanups, the MIPS buildbot compilation fails. In my defense, I did get a build fail email report, but it points at: http://gdb-build.sergiodj.net/builders/Debian-MIPS-m64/builds/77 and looking at: http://gdb-build.sergiodj.net/builders/Debian-MIPS-m64/builds/77/steps/compile%20gdb/logs/stdio it shows the build had failed for an unrelated issue: tdep.Tpo ../../binutils-gdb/gdb/i386obsd-tdep.c In file included from ../../binutils-gdb/gdb/common/common-defs.h:32:0, from ../../binutils-gdb/gdb/defs.h:28, from ../../binutils-gdb/gdb/i386obsd-tdep.c:20: build-gnulib/import/stdlib.h:41:20: fatal error: /usr/lib/gcc/mips-linux-gnu/4.9/include/ctddef.h: No such file or directory #include ^ compilation terminated. The bug is not reproducible, so it is likely a hardware or OS problem. make[2]: *** [i386obsd-tdep.o] Error 1 Makefile:1133: recipe for target 'i386obsd-tdep.o' failed So I just ignored it. Guess I was "lucky". >> Code in MIPS native uses ptrace with 3 arguments, where ptrace requires >> 4. When looking at the definition of ptrace in >> /usr/include/sys/ptrace.h, it shows that it takes a variable number of >> arguments. The wrapper macro in nat/gdb_ptrace.h takes a fixed number >> of arguments (4). That would explain why it used to work and stopped. >> >> I am pushing this as obvious, tell me if there is any problem. Yes, that's the right fix: https://sourceware.org/ml/gdb-patches/2015-07/msg00721.html > Also, I cancelled the current build as well as all pending builds before this commit > on the MIPS builder, in case you were wondering where they all went. There is no > point in spending over 24 hours building code we know won't build. Thanks. -- Pedro Alves