From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 99313 invoked by alias); 29 Jul 2015 11:38:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 99300 invoked by uid 89); 29 Jul 2015 11:38:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 29 Jul 2015 11:38:13 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id F16EAA12FF; Wed, 29 Jul 2015 11:38:11 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t6TBcAF5020188; Wed, 29 Jul 2015 07:38:11 -0400 Message-ID: <55B8BB22.40708@redhat.com> Date: Wed, 29 Jul 2015 11:38:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Patrick Palka CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH] Fix assert failure in invocation of "[kill|detach] inferiors 1" References: <1438115396-7256-1-git-send-email-patrick@parcs.ath.cx> <55B8134A.9020308@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-07/txt/msg00864.txt.bz2 On 07/29/2015 12:22 PM, Patrick Palka wrote: > Ah, so the internal error may also be triggered by passing to these > commands an inferior that is not being run, not just by passing the > initial dummy inferior. I will change the test file to cover these > bases. Yeah. The initial inferior is no different from any other inferior that is created afterwards. > I notice that "[kill|attach] inferiors" has no test coverage > at all, so this will be a good time to add some. Thanks, that's super. -- Pedro Alves