From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 62671 invoked by alias); 28 Jul 2015 23:53:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 62662 invoked by uid 89); 28 Jul 2015 23:53:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 28 Jul 2015 23:53:45 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id F135EAB994; Tue, 28 Jul 2015 23:53:43 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t6SNrgC0003959; Tue, 28 Jul 2015 19:53:43 -0400 Message-ID: <55B81606.6090706@redhat.com> Date: Tue, 28 Jul 2015 23:53:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Patrick Palka , gdb-patches@sourceware.org Subject: Re: [PATCH] Make sure terminal settings are restored before exiting References: <1438053504-21507-1-git-send-email-patrick@parcs.ath.cx> <1438122009-28779-1-git-send-email-patrick@parcs.ath.cx> In-Reply-To: <1438122009-28779-1-git-send-email-patrick@parcs.ath.cx> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-07/txt/msg00851.txt.bz2 (Small request: I find it helpful when the proposed commit log is always present in patch resubmissions, making patches self-contained.) > diff --git a/gdb/top.c b/gdb/top.c > index 1e30b1c..6df987a 100644 > --- a/gdb/top.c > +++ b/gdb/top.c > @@ -66,6 +66,7 @@ > #include "cli-out.h" > #include "tracepoint.h" > #include "inf-loop.h" > +#include "tui/tui.h" > > extern void initialize_all_files (void); > > @@ -1494,6 +1495,14 @@ quit_force (char *args, int from_tty) > int exit_code = 0; > struct qt_args qt; > > + /* Make sure that the terminal is left in the state we acquired it. */ > + target_terminal_ours (); > +#if defined(TUI) > + tui_disable (); > +#endif > + if (async_command_editing_p) > + gdb_disable_readline (); > + Can you put these new bits in a separate function, and call it here? That'll make it easier to reuse, or play with moving the call elsewhere, if needed. As bonus, if we do the latter, git blame on the function's contents will still blame you. :-) OK with that change. Thanks, Pedro Alves