From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 112552 invoked by alias); 28 Jul 2015 23:23:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 112542 invoked by uid 89); 28 Jul 2015 23:23:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 28 Jul 2015 23:23:24 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 1D68C35B96F; Tue, 28 Jul 2015 23:23:23 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t6SNNLck008338; Tue, 28 Jul 2015 19:23:22 -0400 Message-ID: <55B80EE9.8060902@redhat.com> Date: Tue, 28 Jul 2015 23:23:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Patrick Palka , gdb-patches@sourceware.org Subject: Re: [PATCH] Clean up batch-preserve-term-settings.exp References: <1438117682-22449-1-git-send-email-patrick@parcs.ath.cx> In-Reply-To: <1438117682-22449-1-git-send-email-patrick@parcs.ath.cx> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-07/txt/msg00848.txt.bz2 On 07/28/2015 10:08 PM, Patrick Palka wrote: > See ChangeLog for details. No functional change intended. > > Tested on x86_64 Debian Stretch by verifying that the gdb.log output > remains unchanged for native, gdbserver and extended-gdbserver. > > gdb/testsuite/ChangeLog: > > * gdb.base/batch-preserve-term-settings.exp: Remove top-level > manipulation of saved_gdbflags. > (test_terminal_settings_preserved): Remove global declaration of > the unused variable pagination_prompt. Remove manipulation of > saved_gdbflags. Use a local variable EXTRA_GDBFLAGS instead of > GDBFLAGS. OK. Thanks, Pedro Alves