From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-124750-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 18141 invoked by alias); 28 Jul 2015 10:29:58 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 18123 invoked by uid 89); 28 Jul 2015 10:29:57 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 28 Jul 2015 10:29:57 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (Postfix) with ESMTPS id 1770D341ACF;	Tue, 28 Jul 2015 10:29:56 +0000 (UTC)
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t6SATs1G001454;	Tue, 28 Jul 2015 06:29:55 -0400
Message-ID: <55B759A2.9080809@redhat.com>
Date: Tue, 28 Jul 2015 10:29:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 4/5] Consider addressable memory unit size in various value functions
References: <1437072684-26565-1-git-send-email-simon.marchi@ericsson.com> <1437072684-26565-4-git-send-email-simon.marchi@ericsson.com> <55B22120.5010707@redhat.com> <55B6AB27.707@ericsson.com>
In-Reply-To: <55B6AB27.707@ericsson.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2015-07/txt/msg00821.txt.bz2

On 07/27/2015 11:05 PM, Simon Marchi wrote:
> -      offset += TYPE_FIELD_BITPOS (arg_type, fieldno) / 8;
> +      offset += TYPE_FIELD_BITPOS (arg_type, fieldno) /
> +	          (HOST_CHAR_BIT * unit_size);

wrap in parens so alignment ends up correct (per gnu coding conventions),
and put / operator at beginning of line:

 offset += (TYPE_FIELD_BITPOS (arg_type, fieldno)
	    / (HOST_CHAR_BIT * unit_size));

OK with that change.

Thanks,
Pedro Alves