From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2977 invoked by alias); 28 Jul 2015 10:25:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2370 invoked by uid 89); 28 Jul 2015 10:25:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 28 Jul 2015 10:25:54 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id CF31B8F280; Tue, 28 Jul 2015 10:25:52 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t6SAPpT4025954; Tue, 28 Jul 2015 06:25:52 -0400 Message-ID: <55B758AF.7050205@redhat.com> Date: Tue, 28 Jul 2015 10:25:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH 3/5] Introduce get_value_arch References: <1437072684-26565-1-git-send-email-simon.marchi@ericsson.com> <1437072684-26565-3-git-send-email-simon.marchi@ericsson.com> <55B22112.5000703@redhat.com> <55B6A6FA.4010104@ericsson.com> In-Reply-To: <55B6A6FA.4010104@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-07/txt/msg00820.txt.bz2 On 07/27/2015 10:47 PM, Simon Marchi wrote: > On 15-07-24 07:27 AM, Pedro Alves wrote: >>> diff --git a/gdb/value.c b/gdb/value.c >>> index 6314036..af354de 100644 >>> --- a/gdb/value.c >>> +++ b/gdb/value.c >>> @@ -340,6 +340,12 @@ struct value >>> VEC(range_s) *optimized_out; >>> }; >>> >> >> Missing "/* See foo.h. */ breadcrumb. > > Done, updated version: > > From 89ef69ae7265ae62b7c0faeb502021262c9d0103 Mon Sep 17 00:00:00 2001 > From: Simon Marchi > Date: Fri, 3 Jul 2015 14:36:44 -0400 > Subject: [PATCH] Introduce get_value_arch > > Similar to get_type_arch, used to get the gdbarch associated to a > struct value. > LGTM. > > +/* Return the gdbarch associated to the value. */ ( FWIW, to my non-native ears, "associated with" sounds more natural. I'd write: /* Return the gdbarch associated with the value's type. */ ) Thanks, Pedro Alves