From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 33775 invoked by alias); 27 Jul 2015 18:14:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 33725 invoked by uid 89); 27 Jul 2015 18:14:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg21.ericsson.net Received: from usevmg21.ericsson.net (HELO usevmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 27 Jul 2015 18:14:53 +0000 Received: from EUSAAHC001.ericsson.se (Unknown_Domain [147.117.188.75]) by usevmg21.ericsson.net (Symantec Mail Security) with SMTP id B1.72.07675.BCC06B55; Mon, 27 Jul 2015 12:49:47 +0200 (CEST) Received: from [142.133.110.144] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.77) with Microsoft SMTP Server id 14.3.210.2; Mon, 27 Jul 2015 14:14:50 -0400 Message-ID: <55B6751A.80003@ericsson.com> Date: Mon, 27 Jul 2015 18:14:00 -0000 From: Simon Marchi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Pedro Alves , Subject: Re: [PATCH 00/14] Split generic_val_print in smaller parts References: <1436978863-15125-1-git-send-email-simon.marchi@ericsson.com> <55B16288.5080300@redhat.com> In-Reply-To: <55B16288.5080300@redhat.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg00797.txt.bz2 On 15-07-23 05:54 PM, Pedro Alves wrote: > On 07/15/2015 05:47 PM, Simon Marchi wrote: > >> Simon Marchi (14): >> Factor out print_unpacked_pointer from generic_val_print >> Factor out array printing code from generic_val_print >> Factor out pointer printing code from generic_val_print >> Factor out memberptr printing code from generic_val_print >> Factor out reference printing code from generic_val_print >> Factor out enum printing code from generic_val_print >> Factor out flags printing code from generic_val_print >> Factor out function/method printing code from generic_val_print >> Factor out bool printing code from generic_val_print >> Factor out int printing code from generic_val_print >> Factor out char printing code from generic_val_print >> Factor out float printing code from generic_val_print >> Factor out decfloat printing code from generic_val_print >> Factor out complex printing code from generic_val_print > > I read the whole series. Patches that I didn't comment > on looked OK to me as is. The one's I commented on, > just fix them and push right ahead. > > Nice cleanup! Keep 'em coming. :-) > > Thanks, > Pedro Alves I did the fixes and pushed. I'll post the final versions of the patches that were modified. Thanks Simon