From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-124715-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 90423 invoked by alias); 27 Jul 2015 14:53:25 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 90414 invoked by uid 89); 27 Jul 2015 14:53:24 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 27 Jul 2015 14:53:24 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (Postfix) with ESMTPS id 1798E96C9;	Mon, 27 Jul 2015 14:53:23 +0000 (UTC)
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t6RErLb0004726;	Mon, 27 Jul 2015 10:53:22 -0400
Message-ID: <55B645E1.7060809@redhat.com>
Date: Mon, 27 Jul 2015 14:53:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Patrick Palka <patrick@parcs.ath.cx>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Have SIGTERM promptly quit GDB even when the dummy target is active
References: <1437762829-5214-1-git-send-email-patrick@parcs.ath.cx>
In-Reply-To: <1437762829-5214-1-git-send-email-patrick@parcs.ath.cx>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2015-07/txt/msg00786.txt.bz2

On 07/24/2015 07:33 PM, Patrick Palka wrote:

> gdb/ChangeLog:
> 
> 	* event-top.c (handle_sigterm): Don't inspect
> 	target_can_async_p.  Always set the quit flag and always mark
> 	the async signal handler.

OK.

> +gdb_start
> +
> +set gdb_pid [exp_pid -i [board_info host fileid]]
> +remote_exec host "kill -TERM $gdb_pid"
> +
> +set test "expect eof"
> +
> +gdb_expect 5 {

Any reason not to use gdb_test_multiple, like:

 gdb_test_multiple "" $test {
   -timeout 5
   eof {
      pass $test
   }
 }

?

> +    eof {
> +	pass $test
> +    }
> +    timeout {
> +	fail $test
> +    }
> +}
> 

Thanks,
Pedro Alves