From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-124659-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 55438 invoked by alias); 24 Jul 2015 20:38:41 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 55419 invoked by uid 89); 24 Jul 2015 20:38:40 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2
X-HELO: usevmg20.ericsson.net
Received: from usevmg20.ericsson.net (HELO usevmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 24 Jul 2015 20:38:40 +0000
Received: from EUSAAHC002.ericsson.se (Unknown_Domain [147.117.188.78])	by usevmg20.ericsson.net (Symantec Mail Security) with SMTP id 39.91.12958.74642B55; Fri, 24 Jul 2015 16:05:59 +0200 (CEST)
Received: from [142.133.110.144] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.80) with Microsoft SMTP Server id 14.3.210.2; Fri, 24 Jul 2015 16:38:35 -0400
Message-ID: <55B2A24B.8000209@ericsson.com>
Date: Fri, 24 Jul 2015 20:38:00 -0000
From: Simon Marchi <simon.marchi@ericsson.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: <Paul_Koning@Dell.com>, <eliz@gnu.org>
CC: <sergiodj@redhat.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Make sure GDB uses a valid shell when starting the inferior and to perform the "shell" command
References: <1437761993-18758-1-git-send-email-sergiodj@redhat.com> <55B2850D.6030306@ericsson.com> <87k2tp5q3g.fsf@redhat.com> <838ua52wmp.fsf@gnu.org> <87fv4d5p8l.fsf@redhat.com> <837fpp2uz5.fsf@gnu.org> <94F6A309-A197-4A71-BEB9-42E009DD1EB5@dell.com>
In-Reply-To: <94F6A309-A197-4A71-BEB9-42E009DD1EB5@dell.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
X-SW-Source: 2015-07/txt/msg00730.txt.bz2

On 15-07-24 04:25 PM, Paul_Koning@Dell.com wrote:
> But if you omit a shell, is the user of that shell blocked from using gdb=
?  That=E2=80=99s not a good failure mode.  It seems to me that omitting a =
non-shell is much more forgiving: all that happens is that you don=E2=80=99=
t get the friendly error message.
>=20
> So that says the explicit list should be of non-shells.
>=20
> 	paul

With Eli's suggestion, if SHELL is valid but gdb doesn't know about it (e.g.
SHELL=3D/my/super/duper/shell), it will fall back to using /bin/sh.  So no,
the user wouldn't be blocked.