From: Pedro Alves <palves@redhat.com>
To: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/5] Update comments in struct value for non-8-bits architectures
Date: Fri, 24 Jul 2015 11:27:00 -0000 [thread overview]
Message-ID: <55B22109.5020500@redhat.com> (raw)
In-Reply-To: <1437072684-26565-2-git-send-email-simon.marchi@ericsson.com>
On 07/16/2015 07:51 PM, Simon Marchi wrote:
> gdb/ChangeLog:
>
> * value.c (struct value): Update comments.
Looks good to me, though as mentioned in the other patch, I think
these comments should be explicit in saying "host" and "target". These are
central structures that people study first, and being crystal clear
should help grasp the byte vs memory units concepts sooner.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2015-07-24 11:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-16 18:51 [PATCH 1/5] Update comment for struct type's length field, introduce type_length_units Simon Marchi
2015-07-16 18:51 ` [PATCH 2/5] Update comments in struct value for non-8-bits architectures Simon Marchi
2015-07-24 11:27 ` Pedro Alves [this message]
2015-07-27 21:46 ` Simon Marchi
2015-07-28 10:20 ` Pedro Alves
2015-07-16 18:51 ` [PATCH 3/5] Introduce get_value_arch Simon Marchi
2015-07-24 11:27 ` Pedro Alves
2015-07-27 21:47 ` Simon Marchi
2015-07-28 10:25 ` Pedro Alves
2015-07-28 14:56 ` Simon Marchi
2015-07-28 15:06 ` Simon Marchi
2015-07-16 18:51 ` [PATCH 4/5] Consider addressable memory unit size in various value functions Simon Marchi
2015-07-24 11:27 ` Pedro Alves
2015-07-27 22:05 ` Simon Marchi
2015-07-28 10:29 ` Pedro Alves
2015-07-28 15:07 ` Simon Marchi
2015-07-16 18:51 ` [PATCH 5/5] Add new test internalvar.exp Simon Marchi
2015-07-24 11:41 ` Pedro Alves
2015-07-24 11:26 ` [PATCH 1/5] Update comment for struct type's length field, introduce type_length_units Pedro Alves
2015-07-27 21:37 ` Simon Marchi
2015-07-28 10:19 ` Pedro Alves
2015-07-28 15:04 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B22109.5020500@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox