From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 89340 invoked by alias); 23 Jul 2015 23:26:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 89323 invoked by uid 89); 23 Jul 2015 23:26:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 23 Jul 2015 23:26:36 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 5FE348E66A; Thu, 23 Jul 2015 23:26:35 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t6NNQXKm002680; Thu, 23 Jul 2015 19:26:34 -0400 Message-ID: <55B17829.9080303@redhat.com> Date: Thu, 23 Jul 2015 23:26:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH 6/8] Set proc->priv->new_inferior out of linux_add_process References: <1437392126-29503-1-git-send-email-yao.qi@linaro.org> <1437392126-29503-7-git-send-email-yao.qi@linaro.org> In-Reply-To: <1437392126-29503-7-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-07/txt/msg00674.txt.bz2 On 07/20/2015 12:35 PM, Yao Qi wrote: > Nowadays, we set proc->priv->new_inferior to 1 inside linux_add_process, > and new_inferior is used as a flag to initialise target description later. > linux_add_process is used for the three cases, fork/vfork event > (handle_extended_wait), run the program (linux_create_inferior), and > attach to the process (linux_attach). In the first case, the child's > target description is copied from parent's, so we don't need to initialise > target description again later, which means we don't need to set > proc->priv->new_inferior to 1 in this case. For the rest of two cases, > we need this flag. > > This patch move the code setting proc->priv->new_inferior to 1 inside > linux_add_process to linux_create_inferior and linux_attach. No > functionality is changed. LGTM. Thanks, Pedro Alves