From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 664 invoked by alias); 23 Jul 2015 21:54:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 642 invoked by uid 89); 23 Jul 2015 21:54:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 23 Jul 2015 21:54:19 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 7E12D3500F0; Thu, 23 Jul 2015 21:54:18 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t6NLsHW1026211; Thu, 23 Jul 2015 17:54:17 -0400 Message-ID: <55B16288.5080300@redhat.com> Date: Thu, 23 Jul 2015 21:54:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH 00/14] Split generic_val_print in smaller parts References: <1436978863-15125-1-git-send-email-simon.marchi@ericsson.com> In-Reply-To: <1436978863-15125-1-git-send-email-simon.marchi@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-07/txt/msg00668.txt.bz2 On 07/15/2015 05:47 PM, Simon Marchi wrote: > Simon Marchi (14): > Factor out print_unpacked_pointer from generic_val_print > Factor out array printing code from generic_val_print > Factor out pointer printing code from generic_val_print > Factor out memberptr printing code from generic_val_print > Factor out reference printing code from generic_val_print > Factor out enum printing code from generic_val_print > Factor out flags printing code from generic_val_print > Factor out function/method printing code from generic_val_print > Factor out bool printing code from generic_val_print > Factor out int printing code from generic_val_print > Factor out char printing code from generic_val_print > Factor out float printing code from generic_val_print > Factor out decfloat printing code from generic_val_print > Factor out complex printing code from generic_val_print I read the whole series. Patches that I didn't comment on looked OK to me as is. The one's I commented on, just fix them and push right ahead. Nice cleanup! Keep 'em coming. :-) Thanks, Pedro Alves