From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 101829 invoked by alias); 23 Jul 2015 21:45:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 101817 invoked by uid 89); 23 Jul 2015 21:45:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 23 Jul 2015 21:45:41 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 0A1D031F063; Thu, 23 Jul 2015 21:45:40 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t6NLjcrX021853; Thu, 23 Jul 2015 17:45:39 -0400 Message-ID: <55B16081.5010400@redhat.com> Date: Thu, 23 Jul 2015 21:45:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Simon Marchi , gdb-patches@sourceware.org CC: Simon Marchi Subject: Re: [PATCH 01/14] Factor out print_unpacked_pointer from generic_val_print References: <1436978863-15125-1-git-send-email-simon.marchi@ericsson.com> <1436978863-15125-2-git-send-email-simon.marchi@ericsson.com> In-Reply-To: <1436978863-15125-2-git-send-email-simon.marchi@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-07/txt/msg00664.txt.bz2 On 07/15/2015 05:47 PM, Simon Marchi wrote: > > diff --git a/gdb/valprint.c b/gdb/valprint.c > index 52a386a..eee52c5 100644 > --- a/gdb/valprint.c > +++ b/gdb/valprint.c > @@ -359,6 +359,33 @@ val_print_invalid_address (struct ui_file *stream) > fprintf_filtered (stream, _("")); > } > > +/* Print a pointer based on the type of its target. > + > + Arguments to this functions are roughly the same as those in > + generic_val_print. A difference is that ADDRESS is the address to print, > + with embedded_offset already added. UNRESOLVED_ELTTYPE and ELTTYPE represent the pointed type, > + respectively before and after check_typedef. */ Line too long. Comment seems stale -- there's no UNRESOLVED_ELTTYPE parameter. Otherwise looks good. Thanks, Pedro Alves