From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 45073 invoked by alias); 12 Jul 2015 14:59:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 45057 invoked by uid 89); 12 Jul 2015 14:59:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sun, 12 Jul 2015 14:59:03 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 0464919F205; Sun, 12 Jul 2015 14:59:02 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t6CEwx7R028486; Sun, 12 Jul 2015 10:59:00 -0400 Message-ID: <55A280B3.9050503@redhat.com> Date: Sun, 12 Jul 2015 14:59:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Andrew Burgess CC: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/tui: Add command completion to winheight command. References: <1436534024-23458-1-git-send-email-andrew.burgess@embecosm.com> <559FF19E.3010208@redhat.com> <20150712085140.GE5485@embecosm.com> In-Reply-To: <20150712085140.GE5485@embecosm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-07/txt/msg00352.txt.bz2 On 07/12/2015 09:51 AM, Andrew Burgess wrote: > gdb/ChangeLog: > > * tui/tui-win.c (window_name_completer): New function. > (focus_completer): Call window_name_completer. All old content > moved into window_name_completer. > (winheight_completer): New function. > (_initialize_tui_win): Rename variable. Add completer to > winheight command. Update doc string on winheight. > This is OK. > -/* Complete possible window names to focus on. TEXT is the complete text > - entered so far, WORD is the word currently being completed. */ > +/* Generic window name completion function. Complete window name pointed > + to by TEXT and WORD. If INCLUDE_NEXT_PREV_P is true then the special > + window names 'next' and 'prev' are also included in the list of possible > + completions (if appropriate). */ > I don't really understand what "if appropriate" is referring to, though. Thanks, Pedro Alves