Re: [PATCH 0/7] Split c_val_print

Simon Marchi
2015-07-09T15:28:32Z

On 15-07-09 06:53 AM, Pedro Alves wrote:
> Nice! A couple issues need to be fixed and this is good to go.
>
> - The intro comment to print_unpacked_pointer in patch 2
> uses the wrong format (leading * in each line?).

Ah, that's an artifact from CDT :). Fixed.

> - For convention, make sure there's a line break after
> each variable declaration.

You mean, after each block of variable declarations, and not
after each single variable declaration I suppose?

I only found one instance, in c_val_print_ptr.

> Fix these and push.

Done, thanks.

> Thanks,
> Pedro Alves