From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 80265 invoked by alias); 9 Jul 2015 15:28:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 80255 invoked by uid 89); 9 Jul 2015 15:28:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg21.ericsson.net Received: from usevmg21.ericsson.net (HELO usevmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 09 Jul 2015 15:28:26 +0000 Received: from EUSAAHC002.ericsson.se (Unknown_Domain [147.117.188.78]) by usevmg21.ericsson.net (Symantec Mail Security) with SMTP id A1.A2.07675.6BB2E955; Thu, 9 Jul 2015 10:07:19 +0200 (CEST) Received: from [142.133.110.144] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.80) with Microsoft SMTP Server id 14.3.210.2; Thu, 9 Jul 2015 11:28:23 -0400 Message-ID: <559E9317.1070609@ericsson.com> Date: Thu, 09 Jul 2015 15:28:00 -0000 From: Simon Marchi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Pedro Alves , Subject: Re: [PATCH 0/7] Split c_val_print References: <1436389629-18754-1-git-send-email-simon.marchi@ericsson.com> <559E52B1.9020802@redhat.com> In-Reply-To: <559E52B1.9020802@redhat.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg00292.txt.bz2 On 15-07-09 06:53 AM, Pedro Alves wrote: > Nice! A couple issues need to be fixed and this is good to go. > > - The intro comment to print_unpacked_pointer in patch 2 > uses the wrong format (leading * in each line?). Ah, that's an artifact from CDT :). Fixed. > - For convention, make sure there's a line break after > each variable declaration. You mean, after each block of variable declarations, and not after each single variable declaration I suppose? I only found one instance, in c_val_print_ptr. > Fix these and push. Done, thanks. > Thanks, > Pedro Alves