From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-124216-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 56472 invoked by alias); 9 Jul 2015 12:51:51 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 56458 invoked by uid 89); 9 Jul 2015 12:51:51 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2
X-HELO: eu-smtp-delivery-143.mimecast.com
Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (207.82.80.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 09 Jul 2015 12:51:49 +0000
Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-30-qtDVXTYVQ6eiDkNTinx8tQ-1; Thu, 09 Jul 2015 13:51:43 +0100
Received: from [10.2.207.36] ([10.1.2.79]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959);	 Thu, 9 Jul 2015 13:51:43 +0100
Message-ID: <559E6E5F.7000604@arm.com>
Date: Thu, 09 Jul 2015 12:51:00 -0000
From: Pierre Langlois <pierre.langlois@arm.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Yao Qi <qiyaoltc@gmail.com>
CC: pierre.langlois@arm.com,  "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH v2 4/8] [AArch64] Teach prologue unwinder to terminate gracefully
References: <86pp42mxbz.fsf@gmail.com>	<1436438962-2794-1-git-send-email-pierre.langlois@arm.com> <86vbdtlcqr.fsf@gmail.com>
In-Reply-To: <86vbdtlcqr.fsf@gmail.com>
X-MC-Unique: qtDVXTYVQ6eiDkNTinx8tQ-1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
X-SW-Source: 2015-07/txt/msg00287.txt.bz2

On 09/07/15 13:46, Yao Qi wrote:
> Pierre Langlois <pierre.langlois@arm.com> writes:
>=20
>> +/* Allocate and fill in *THIS_CACHE with information about the prologue=
 of
>> +   *THIS_FRAME.  Do not do this is if *THIS_CACHE was already allocated.
>> +   Return a pointer to the current aarch64_prologue_cache in *THIS_CACH=
E.
>> +   */
>=20
> We don't write */-only line in the comment.  See "Block Comment Formattin=
g"
> in https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards
>=20
> You can change it to
>       ...
>       *THIS_CACHE.  */
>=20

Oh I see, sorry I missed this.  I'll update this comment on the other
patches too.