From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16327 invoked by alias); 8 Jul 2015 15:06:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15869 invoked by uid 89); 8 Jul 2015 15:06:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 08 Jul 2015 15:06:17 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id C2082349E43; Wed, 8 Jul 2015 15:06:15 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t68F6DtU030287; Wed, 8 Jul 2015 11:06:14 -0400 Message-ID: <559D3C65.5040909@redhat.com> Date: Wed, 08 Jul 2015 15:06:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Patrick Palka , gdb-patches@sourceware.org Subject: Re: [PATCH] tui: replace deprecated_register_changed_hook with observer References: <559D2B1F.1080503@redhat.com> <1436364665-16937-1-git-send-email-patrick@parcs.ath.cx> In-Reply-To: <1436364665-16937-1-git-send-email-patrick@parcs.ath.cx> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-07/txt/msg00222.txt.bz2 On 07/08/2015 03:11 PM, Patrick Palka wrote: > This is a straightforward replacement of the TUI's use of the > aforementioned hook with the register_changed observer. Since this was > the only user of the hook, this patch also removes the hook. OK. (Note: I'm aware that insight uses some of the these deprecated hooks, but as we're showing how to convert them to observers at the same time, I think that's fine; insight can be converted as it pulls in newer gdb; otherwise it seems like at the pace it's been taking, we'd never manage to get rid of the deprecated hooks.) Thanks, Pedro Alves