From: Simon Marchi <simon.marchi@ericsson.com>
To: Pedro Alves <palves@redhat.com>, Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: Should this be on the blocker list for the 7.10 release?
Date: Tue, 07 Jul 2015 18:35:00 -0000 [thread overview]
Message-ID: <559C1BFB.7070308@ericsson.com> (raw)
In-Reply-To: <559C14B6.5020800@redhat.com>
> OK, the issue is that the new clone thread is found while inside
> the linux_stop_and_wait_all_lwps call in this new bit of
> code in linux-thread-db.c:
>
> linux_stop_and_wait_all_lwps ();
>
> ALL_LWPS (lp)
> if (ptid_get_pid (lp->ptid) == pid)
> thread_from_lwp (lp->ptid);
>
> linux_unstop_all_lwps ();
>
> We reach linux_handle_extended_wait with the "stopping"
> parameter set to 1, and because of that we don't mark the
> new lwp as resumed. As consequence, the subsequent
> resume_stopped_resumed_lwps (called first from that
> linux_unstop_all_lwps) never resumes the new LWP...
>
> There's lots of cruft in linux_handle_extended_wait that no
> longer makes sense. This seems to fix your github test
> for me, and causes no testsuite regressions.
It seems to fix most of it. The only odd thing left that I
noticed is that it leaves some of the inferiors there. When I
type "info inferiors" after running the program, I see one or
two of them left. I believe there should only be inferior #1
left.
> Did you try converting your test case to a proper
> GDB test? That'd be much appreciated.
I haven't, but I will.
Thanks!
next prev parent reply other threads:[~2015-07-07 18:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-06 20:26 Simon Marchi
2015-07-07 13:25 ` Joel Brobecker
2015-07-07 16:18 ` Pedro Alves
2015-07-07 18:04 ` Pedro Alves
2015-07-07 18:35 ` Simon Marchi [this message]
2015-07-07 18:47 ` Pedro Alves
2015-07-07 19:04 ` Pedro Alves
2015-07-07 19:20 ` Pedro Alves
2015-07-07 20:38 ` Simon Marchi
2015-07-07 22:04 ` Simon Marchi
2015-07-13 19:20 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559C1BFB.7070308@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox