From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 122475 invoked by alias); 6 Jul 2015 15:33:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 122466 invoked by uid 89); 6 Jul 2015 15:33:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 06 Jul 2015 15:33:41 +0000 Received: from svr-orw-fem-04.mgc.mentorg.com ([147.34.97.41]) by relay1.mentorg.com with esmtp id 1ZC8On-0003sJ-25 from Luis_Gustavo@mentor.com ; Mon, 06 Jul 2015 08:33:37 -0700 Received: from [172.30.7.214] (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.3.224.2; Mon, 6 Jul 2015 08:33:36 -0700 Message-ID: <559A9FCE.5070908@codesourcery.com> Date: Mon, 06 Jul 2015 15:33:00 -0000 From: Luis Machado Reply-To: Luis Machado User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Pedro Alves , Subject: Re: [PATCH] Fix problems with finishing a dummy function call on simulators. References: <1433862056-18237-1-git-send-email-lgustavo@codesourcery.com> <55772797.802@redhat.com> <55805F52.20805@codesourcery.com> <55816AD5.6020605@redhat.com> <55817569.7060704@codesourcery.com> <5581798B.5080207@redhat.com> <5581D5A9.3070706@codesourcery.com> <559A998E.6010500@redhat.com> In-Reply-To: <559A998E.6010500@redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg00124.txt.bz2 On 07/06/2015 12:06 PM, Pedro Alves wrote: > Hi Luis, > > Looks like this regressed gdbserver somehow. > > On 06/17/2015 09:16 PM, Luis Machado wrote: >> On 06/17/2015 10:43 AM, Pedro Alves wrote: >>> On 06/17/2015 02:26 PM, Luis Machado wrote: >>>> On 06/17/2015 09:40 AM, Pedro Alves wrote: >>> >>>>> Yep. Close, but also remove the bp_call_dummy check in >>>>> bp_loc_is_permanent, and merge in its comment, like ... >>>>> >>>> >>>> Fixed now. >>> >>> Looks good now. Thanks. >>> >>>> The attached updated patch also removes this dead function. I can commit >>>> it as a separate patch if you're not removing it yourself. >>> >>> Nah, I was hoping you'd remove it. :-) Please also remove the >>> make_breakpoint_permanent declaration from breakpoint.h though. >> >> Thanks. I've pushed this in now and pushed the removal with a different >> patch. >> > > Compared to before the patch, I see these: > > -PASS: gdb.base/shlib-call.exp: print mainshr1(1) > -PASS: gdb.base/shlib-call.exp: step into mainshr1 > +FAIL: gdb.base/shlib-call.exp: print mainshr1(1) > +FAIL: gdb.base/shlib-call.exp: step into mainshr1 > PASS: gdb.base/shlib-call.exp: set print sevenbit-strings > PASS: gdb.cp/chained-calls.exp: g(f()) > -PASS: gdb.cp/chained-calls.exp: q(p()) > +FAIL: gdb.cp/chained-calls.exp: q(p()) > PASS: gdb.cp/chained-calls.exp: p() + r() > -PASS: gdb.cp/chained-calls.exp: q(p() + r()) > +FAIL: gdb.cp/chained-calls.exp: q(p() + r()) > PASS: gdb.cp/chained-calls.exp: g(f() + f()) > -PASS: gdb.cp/chained-calls.exp: g(f(g(f() + f())) + f()) > +FAIL: gdb.cp/chained-calls.exp: g(f(g(f() + f())) + f()) > PASS: gdb.cp/chained-calls.exp: getb(makeb(), ...) > -PASS: gdb.cp/chained-calls.exp: *c > -PASS: gdb.cp/chained-calls.exp: *c + *c > -PASS: gdb.cp/chained-calls.exp: q(*c + *c) > +FAIL: gdb.cp/chained-calls.exp: *c > +FAIL: gdb.cp/chained-calls.exp: *c + *c > +FAIL: gdb.cp/chained-calls.exp: q(*c + *c) > > PASS: gdb.cp/classes.exp: print cnsi with static members > PASS: gdb.cp/classes.exp: finish from marker_reg1 > -PASS: gdb.cp/classes.exp: calling method for small class > +FAIL: gdb.cp/classes.exp: calling method for small class > > git bisect pointed to this commit: > > 6ae8866180bf90e9ec76c2dd34c07fd826d11a83 is the first bad commit > commit 6ae8866180bf90e9ec76c2dd34c07fd826d11a83 > Author: Luis Machado > Date: Wed Jun 17 16:50:57 2015 -0300 > > Fix problems with finishing a dummy function call on simulators. > > I don't have an offhand explanation for the regressions. > > This is just: > > make check RUNTESTFLAGS="--target_board=native-gdbserver" > > on x86_64 Fedora 20. > > Thanks, > Pedro Alves > I'll take a look at it. I suppose this will block the branching? Then again, simply reverting this will still have bad results with some simulators.