From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 79582 invoked by alias); 17 Oct 2017 10:06:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 79572 invoked by uid 89); 17 Oct 2017 10:06:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=delighted X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Oct 2017 10:06:30 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B2B15276C21; Tue, 17 Oct 2017 10:06:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com B2B15276C21 Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id E07EF5E24E; Tue, 17 Oct 2017 10:06:27 +0000 (UTC) Subject: Re: [PATCH 1/2] GDB test suite: Add helper for locating core files To: Andreas Arnez References: <1505760152-28775-1-git-send-email-arnez@linux.vnet.ibm.com> <1505760152-28775-2-git-send-email-arnez@linux.vnet.ibm.com> <20171007094545.1bba5c51@pinnacle.lan> Cc: Kevin Buettner , gdb-patches@sourceware.org From: Pedro Alves Message-ID: <5598e931-a904-ea08-def4-054af62ba71a@redhat.com> Date: Tue, 17 Oct 2017 10:06:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-10/txt/msg00500.txt.bz2 On 10/12/2017 06:00 PM, Andreas Arnez wrote: > On Thu, Oct 12 2017, Pedro Alves wrote: > >> On 10/09/2017 07:46 PM, Andreas Arnez wrote: >> >>> @@ -5883,7 +5883,7 @@ proc run_and_get_core {binfile {arg ""}} { >>> # specified. Return that path name, or "" if no core file was found. >>> >>> proc find_core {binfile coredir {destcore ""}} { >>> - if {[is_remote target]} { >>> + if {![isnative]} { >>> warning "Can not access remote core file." >>> return "" >>> } >> >> This seems incorrect to me. "isnative" only checks >> if the build and target _triplets_ are the same. So >> foo-linux-gnu gdb x foo-linux-gnu gdbserver on separate >> machine still returns isnative==true. > > Exactly, that's why I originally wrote is_remote instead. And I also > wondered why the core dump tests check isnative. Does anyone run the > testsuite on a native remote setup? I think most if not all isnative checks are stale/bogus, and likely were introduced at a time when cross debugging, including cross-core debugging wasn't that well supported. I'd be delighted to see them cleaned up and replaced with a more appropriate check. > Right, this seems all a bit mixed up to me, similar to the confusing > remote_file and remote_exec operations in core_find. I wonder whether it'd be equally simple to move in the opposite direction of making these operations use the right FOO "remote_exec FOO", making it easier to actually support remote core dump testing. (Maybe not by default, since uploading the cores may be slow, but with a board option/setting.) Thanks, Pedro Alves