From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 104124 invoked by alias); 2 Jul 2015 15:34:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 104048 invoked by uid 89); 2 Jul 2015 15:34:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f42.google.com Received: from mail-pa0-f42.google.com (HELO mail-pa0-f42.google.com) (209.85.220.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 02 Jul 2015 15:34:18 +0000 Received: by pacws9 with SMTP id ws9so42935269pac.0 for ; Thu, 02 Jul 2015 08:34:15 -0700 (PDT) X-Received: by 10.68.57.226 with SMTP id l2mr48564144pbq.61.1435851255767; Thu, 02 Jul 2015 08:34:15 -0700 (PDT) Received: from [127.0.0.1] (gcc1-power7.osuosl.org. [140.211.15.137]) by mx.google.com with ESMTPSA id nm9sm6083101pdb.26.2015.07.02.08.34.13 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 Jul 2015 08:34:15 -0700 (PDT) Message-ID: <559559F2.90700@gmail.com> Date: Thu, 02 Jul 2015 15:34:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Patrick Palka CC: Doug Evans , Keith Seitz , gdb-patches Subject: Re: Several regressions and we branch soon. References: <5589BECB.7090200@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg00081.txt.bz2 Hi Patrick, After discussing with Walfred Tedeschi on intel mpx, I think command "show mpx bound" still needs an input argument, otherwise, GDB will display many bound table entries, which is less useful to users. I don't want to rename the command to "show-mpx-bound", because GDB doesn't have any other "show-*" commands. So looks your fix is the best one I can think of. On 23/06/15 22:45, Patrick Palka wrote: > diff --git a/gdb/i386-tdep.c b/gdb/i386-tdep.c > index 42d0346..d11efa1 100644 > --- a/gdb/i386-tdep.c > +++ b/gdb/i386-tdep.c > @@ -8777,11 +8777,17 @@ i386_mpx_info_bounds (char *args, int from_tty) > struct type *data_ptr_type = builtin_type (gdbarch)->builtin_data_ptr; > > if (!i386_mpx_enabled ()) > - error (_("Intel(R) Memory Protection Extensions not\ > - supported on this target.")); > + { > + printf_unfiltered (_("Intel(R) Memory Protection Extensions not " > + "supported on this target.\n")); The indentation looks wrong to me. > + return; > + } Could you add the changelog entry in your patch, and post it again? Then, it can be reviewed properly. -- Yao (齐尧)