From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26992 invoked by alias); 2 Jul 2015 11:38:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26979 invoked by uid 89); 2 Jul 2015 11:38:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 02 Jul 2015 11:38:54 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 5DA072D44E6; Thu, 2 Jul 2015 11:38:53 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t62Bcpas015569; Thu, 2 Jul 2015 07:38:52 -0400 Message-ID: <559522CB.5080403@redhat.com> Date: Thu, 02 Jul 2015 11:38:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Gary Benson CC: gdb-patches@sourceware.org, =?UTF-8?B?Q8OpZHJpYyBCdWlzc2FydA==?= Subject: Re: [PATCH 1/5] Introduce build_debug_file_name References: <1434447768-17328-1-git-send-email-gbenson@redhat.com> <1434447768-17328-2-git-send-email-gbenson@redhat.com> <5593C985.7020204@redhat.com> <20150702111821.GA17978@blade.nx> In-Reply-To: <20150702111821.GA17978@blade.nx> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-07/txt/msg00075.txt.bz2 On 07/02/2015 12:18 PM, Gary Benson wrote: > Pedro Alves wrote: >> On 06/16/2015 10:42 AM, Gary Benson wrote: >>> This commit introduces a new function build_debug_file_name which >>> concatenates a series of filename components into a filename. >>> find_separate_debug_file is updated to use build_debug_file_name. >>> A later commit in this series will extend build_debug_file_name to >>> correctly handle "target:" prefixes, so it is convenient to have >>> filename building pulled out into one function. For now the only >>> functional change here is that the original code sometimes >>> generated filenames with repeated directory separators while the >>> new code does not. >> >> I'd drop the "debug" from the function's name. Sounds like a >> candidate for reuse elsewhere to me. > > Should I put it somewhere else, maybe common-utils.c? I dislike common-utils.c for "kitchen-sink" reasons, though. There's common/filestuff.c, but that looks more for low/OS level file things. There's substitute_path_component (and gdb_realpath / gdb_abspath) in utils.c. Maybe put it next to substitute_path_component, which seems to be in the same "family" of function, and then (at some point) we would move all file name/path manipulation routines to its own file. WDYT? Thanks, Pedro Alves