From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4473 invoked by alias); 2 Jul 2015 09:09:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4464 invoked by uid 89); 2 Jul 2015 09:09:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 02 Jul 2015 09:09:27 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 1409EABA; Thu, 2 Jul 2015 09:09:26 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t6299OKZ000458; Thu, 2 Jul 2015 05:09:25 -0400 Message-ID: <5594FFC4.4080803@redhat.com> Date: Thu, 02 Jul 2015 09:09:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH 11/11] New target_ops hook to_can_do_single_step References: <1435759111-22856-1-git-send-email-yao.qi@linaro.org> <1435759111-22856-12-git-send-email-yao.qi@linaro.org> <55941892.3000902@redhat.com> <866163os3x.fsf@gmail.com> In-Reply-To: <866163os3x.fsf@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-07/txt/msg00071.txt.bz2 On 07/02/2015 09:56 AM, Yao Qi wrote: > Pedro Alves writes: > >> But my issue with it is that this breaks gdb/gdbserver compatibility. >> >> Old GDB has: >> >> /* If s, S, c, and C are not all supported, we can't use vCont. Clearing >> BUF will make packet_ok disable the packet. */ >> if (!support_s || !support_S || !support_c || !support_C) >> buf[0] = 0; >> >> Which means that new x86-86 gdbserver with old gdb will just >> stop using vCont after this change. > > I think you meant new arm gdbserver, which doesn't return s and S in the > reply, old gdb will stop using vCont. Yeah. > >> >> And old arm gdbserver will still claim support for vCont;s packets, >> which means that new gdb with old gdbserver will be broken. > > That is right. I'll do it in qSupported features. Thanks. -- Pedro Alves