Re: [PATCH 11/11] New target_ops hook to_can_do_single_step

Pedro Alves
2015-07-02T09:09:28Z

On 07/02/2015 09:56 AM, Yao Qi wrote:
> Pedro Alves <palves@redhat.com> writes:
>
>> But my issue with it is that this breaks gdb/gdbserver compatibility.
>>
>> Old GDB has:
>>
>> /* If s, S, c, and C are not all supported, we can't use vCont. Clearing
>> BUF will make packet_ok disable the packet. */
>> if (!support_s || !support_S || !support_c || !support_C)
>> buf[0] = 0;
>>
>> Which means that new x86-86 gdbserver with old gdb will just
>> stop using vCont after this change.
>
> I think you meant new arm gdbserver, which doesn't return s and S in the
> reply, old gdb will stop using vCont.

Yeah.

>
>>
>> And old arm gdbserver will still claim support for vCont;s packets,
>> which means that new gdb with old gdbserver will be broken.
>
> That is right. I'll do it in qSupported features.

Thanks.

--
Pedro Alves