[PATCH 0/5] Separate debugfile improvements

Gary Benson
2015-06-16T09:42:55Z

Hi all,

This series makes a number of improvements to the code that locates
separated debuginfo. This series (patch 4 specifically) goes really
nicely with the remote/container improvements I made this past few
months, and it'd be really nice to get this into 7.10.

- Patch 1 pulls filename building (including buffer allocation) out of
find_separate_debug_file into a new function, build_debug_file_name.
This simplifies find_separate_debug_file ready for the other
patches. The new code avoids generating paths with repeated
separators, but operation is otherwise unchanged.

- Patch 2 alters find_separate_debug_file's caller to supply all paths
without trailing separators, which patch 1 of this series made
unnecessary. This allows paths to be compared more simply.

- Patch 3 changes how find_separate_debug_file's CANON_DIR argument is
handled. The new code avoids looking in CANON_DIR if it is the same
as DIR, but operation is otherwise unchanged.

- Patch 4 updates find_separate_debug_file to handle filenames
prefixed with "target:". This allows GDB to locate and access
separated debuginfo from remote targets and from inferiors in
containers.

- Patch 5 causes GDB to look for debug files in gdb_sysroot in
addition to the other searched locations. This allows for easier
analysis of core files from foreign machines.

Built and regtested on RHEL 6.6 x86_64.

Ok to commit?

Thanks,
Gary

--