From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 33887 invoked by alias); 1 Jul 2015 11:13:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 33876 invoked by uid 89); 1 Jul 2015 11:13:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 01 Jul 2015 11:13:24 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 09496C787B; Wed, 1 Jul 2015 11:13:23 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t61BDLI1016270; Wed, 1 Jul 2015 07:13:21 -0400 Message-ID: <5593CB50.90608@redhat.com> Date: Wed, 01 Jul 2015 11:13:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Gary Benson , gdb-patches@sourceware.org CC: =?windows-1252?Q?C=E9dric_Buissart?= Subject: Re: [PATCH 3/5] Update how find_separate_debug_file handles CANON_DIR argument References: <1434447768-17328-1-git-send-email-gbenson@redhat.com> <1434447768-17328-4-git-send-email-gbenson@redhat.com> In-Reply-To: <1434447768-17328-4-git-send-email-gbenson@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-07/txt/msg00007.txt.bz2 On 06/16/2015 10:42 AM, Gary Benson wrote: > find_separate_debug_file's CANON_DIR argument is used to create an > alternate location to search for debug files. This commit moves > that logic out of the loop it's in and introduces a new variable > altdir to hold the generated alternate location. A check is added > to inhibit the altdir search if alternate location is the same as > the regular location specified in DIR. A check was also added for > gdb_sysroot == NULL, which the original code was missing. I think the "gdb_sysroot != NULL" check is no longer necessary, right? Otherwise looks fine. Thanks, Pedro Alves