From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 82347 invoked by alias); 1 Jul 2015 10:32:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 82338 invoked by uid 89); 1 Jul 2015 10:32:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 01 Jul 2015 10:32:19 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 7228ABF9DD for ; Wed, 1 Jul 2015 10:32:18 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t61AWGif012080; Wed, 1 Jul 2015 06:32:17 -0400 Message-ID: <5593C1B0.1050606@redhat.com> Date: Wed, 01 Jul 2015 10:32:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Jan Kratochvil , gdb-patches@sourceware.org CC: Phil Muldoon Subject: Re: [patchv2] compile: Fix crash on cv-qualified self-reference References: <20150418172843.GA17777@host1.jankratochvil.net> <20150516132555.GB17266@host1.jankratochvil.net> In-Reply-To: <20150516132555.GB17266@host1.jankratochvil.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-SW-Source: 2015-07/txt/msg00005.txt.bz2 On 05/16/2015 02:25 PM, Jan Kratochvil wrote: > On Sat, 18 Apr 2015 19:28:43 +0200, Jan Kratochvil wrote: > Hi, > > with this modified testcase GDB would: > > compile code struct_object.selffield = &struct_object > ./compile/compile-c-types.c:83: internal-error: insert_type: Assertion `add == NULL || add->gcc_type == gcc_type' failed. > A problem internal to GDB has been detected, > further debugging may prove unreliable. > Quit this debugging session? (y or n) FAIL: gdb.compile/compile.exp: compile code struct_object.selffield = &struct_object (GDB internal error) > > While the insert_type() assertion looks unclear trying to fix it one ends up > with either GCC crash > [gcc libcc1] build_qualified_type for self-referencing/incomplete types > https://gcc.gnu.org/ml/gcc/2015-04/msg00108.html > c_incomplete_type_error() > or after fixing up the GCC type for proper error reporting one gets: > gdb command line:1:1: error: invalid use of incomplete typedef ‘sv’ > which is the real culprit of this bug as explained in this patch. > > This patch is related to the XFAIL introduced by > [PATCH v3 5/9] compile: Use -Wall, not -w > https://sourceware.org/ml/gdb-patches/2015-04/msg00429.html > as for proper -Wall happiness the 'volatile' qualifier needs to be added there > - but adding the qualifier has caused this crash. > > No regressions on {x86_64,x86_64-m32,i686}-fedora23pre-linux-gnu. OK. Sorry for the delay. Thanks, Pedro Alves