From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 129906 invoked by alias); 1 Jul 2015 09:30:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 129884 invoked by uid 89); 1 Jul 2015 09:30:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_00,MIME_BASE64_BLANKS,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mga11.intel.com Received: from mga11.intel.com (HELO mga11.intel.com) (192.55.52.93) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 01 Jul 2015 09:30:28 +0000 Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 01 Jul 2015 02:30:26 -0700 X-ExtLoop1: 1 Received: from wtedesch-mobl2.ger.corp.intel.com (HELO [172.28.205.57]) ([172.28.205.57]) by fmsmga001.fm.intel.com with ESMTP; 01 Jul 2015 02:30:25 -0700 Message-ID: <5593B32F.6070503@intel.com> Date: Wed, 01 Jul 2015 09:30:00 -0000 From: Walfred Tedeschi User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: "Tedeschi, Walfred" CC: "Yao Qi ; Patrick Palka ; Doug Evans ; Keith Seitz ; gdb-patches" Subject: Re: Several regressions and we branch soon. References: <5589BECB.7090200@redhat.com> <86mvzpqq1z.fsf@gmail.com> <86pp4cp8ii.fsf@gmail.com> In-Reply-To: Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: base64 X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg00003.txt.bz2 SGVsbG8gWWFvLAoKVGhhbmsgeW91IGZvciB5b3VyIGZlZWRiYWNrIQoKU2Vl IGJlbG93OgoKPiBUaGlzIGNvbW1hbmQgd2FzIHByb3Bvc2VkIGluaXRpYWxs eSBhcyBhbiBzdGFuZGFsb25lIGxpa2U6IAo+IFNldC1tcHgtYm91bmQgYW5k IHNob3ctbXB4LWJvdW5kLiBSZWNvbW1lbmRhdGlvbiB3YXMgdG8gaW50cm9k dWNlIGl0IAo+IGluIHRoZSBzZXRzIGFuZCBzaG93cywgd2hpY2ggSSBoYXZl IGFncmVlZC4gQWxzbyBiZWNhdXNlICJzZXQiIGlzIGFsc28gCj4gdXNlZCB0 byBzZXQgdmFsdWVzIG9mIHZhcmlhYmxlcyB3aGVuIHVzZWQgYWxvbmUuIFdo aWNoIGlzIHNpbWlsYXIgdG8gCj4gd2hhdCAic2V0IG1weCBib3VuZCIgaXMg ZG9pbmcsIEluIHRoaXMgc2Vuc2UgaXQgY2FuIGJlIGNvbnNpZGVyZWQgYXMg Cj4gdGhlIHJpZ2h0IGNhdGVnb3J5IHRvIGhhdmUgaXQsIGFzIEpvZWwgaW5k aWNhdGVkLiBBYm91dCB0aGUgc2hvdywgd2VsbCAKPiB0aGF0IGlzIHRoZSBu YXR1cmFsIGNvdW50ZXJwYXJ0IG9mIHRoZSBzZXQsIHJpZ2h0PyBBbHNvLCBJ IGFncmVlIHdpdGggCj4gWWFvIHBhdGNoLiBJIHdvdWxkIHVzZSBhICJ3YXJu aW5nIiBpbnN0ZWFkLiBJbml0aWFsaXphdGlvbiBvZiB0aGUgCj4gY29tbWFu ZCBjYW4gYmUgcGxhY2VkIGluIGEgZGlmZmVyZW50IGxvY2F0aW9uLiBJIGNv dWxkIHRoaW5rIG9mIGFkZGluZyAKPiB0aGVtIGF0IHRoZSB2YWxpZGF0aW9u IG9mIHRoZSB0ZGVzYywgaS5lLiBJMzg2X3ZhbGlkYXRlX3RkZXNjX3AgYW5k IAo+IGFtZDY0X3ZhbGlkYXRlX3RkZXNjX3AuIFdvdWxkIHlvdSBhZ3JlZSB3 aXRoIHRoYXQ/IE9wZW4gcXVlc3Rpb25zIGFyZTogCj4gMS4gQ29tbWFuZCBj YWxsLiBTaG91bGQgdGhleSBzdGlsbCBiZSBjYWxsZWQgInNldCBtcHggYm91 bmQiIC8gInNob3cgCj4gbXB4IGJvdW5kIgo+IENvbW1hbmQgInNob3cgbXB4 IGJvdW5kIiBleHBlY3RzIGFuIGFyZ3VtZW50LCB3aGljaCBpcyBhbiBhZGRy ZXNzLiAgSXMgdGhpcyBhcmd1bWVudCBtYW5kYXRvcnk/ICBJbiBvdGhlciB3 b3JkcywgY2FuIGdkYiBzY2FuIGJvdW5kIGRpcmVjdG9yeSBhbmQgYm91bmQg dGFibGUgZnJvbSBpbmZlcmlvciBtZW1vcnkgYW5kIHByaW50IGFsbCBlbnRy aWVzPyB0aGlzIHdvdWxkIGJlIHNsb3csIGJ1dCAic2hvdyBtcHggYm91bmQi IGRvZXNuJ3QgbmVlZCBhbiBhcmd1bWVudC4KVGhvdWdoIHNsb3cgaSB0aGlu ayBpdCBjb3VsZCBiZSBkb25lLiBJbiBjYXNlIG9mIGRpc3BsYXlpbmcgYWxs IGVudHJpZXMgCnRoZXJlIHdpbGwgYmUgbm8gY29udGV4dCBmb3IgdGhlIHVz ZXIuIEl0IG1lYW5zIGhlIHdpbGwgc2UgYSBiaWcgdGFibGUgCm9mIG51bWJl cnMuICBUaGVyZWZvcmUgd2UgZGVjaWRlZCB0byBkaXNwbGF5IG9ubHkgZm9y IHRoZSBwb2ludGVyIGRlc2lyZWQuCkluIGNhc2UgeW91IGd1eXMgdGhpbmsg dGhhdCBpdCBtaWdodCBiZSBhbHNvIGludGVyZXN0aW5nIHdlIGNvdWxkIHNw YW5kIAp0aGUgY29tbWFuZCB3b3JrIGluIHRoYXQgd2F5Lgo+IEFmdGVyIEkg cmVhZCBpbnRlbCBtcHggZG9jIGFuZCB0aGUgcGF0Y2gsIEkgaGF2ZSBtb3Jl IHF1ZXN0aW9ucyBpbiBteSBtaW5kLAo+Cj4gICAtIGlmIHByb2dyYW0gZG9l c24ndCBzZXQgbXB4IGJvdW5kcyBhdCBhbGwsIEdEQiBhdHRhY2hlcyB0byB0 aGUgcHJvZ3JhbSwKPiAgICAgYW5kIHNldCBtcHggYm91bmRzLCB3aGVuIEdE QiBkZXRhY2hlcyBmcm9tIHRoaXMgcHJvZ3JhbSwgZG9lcyBHREIKPiAgICAg bmVlZCB0byBjbGVhciB0aGVzZSBtcHggYm91bmRzIGl0IHNldHM/CkluIGNh c2UgcHJvZ3JhbSBkb2VzIG5vdCBzZXQgYm91bmRzIEdEQiB3aWxsIGFsc28g bm90IGFibGUgdG8gc2V0IApib3VuZHMuIEJhc2ljYWxseSBpZGVhIGlzIHRv IGhhdmUgYm91bmRzIGFzIHZhcmlhYmxlcy4KT25jZSB1c2VyIGhhcyBtb2Rp ZmllZCBpdHMgZG9uZS4KPiAgIC0gaWYgcHJvZ3JhbSBkb2VzIHNldCBtcHgg Ym91bmRzIHRvbyAodGhyb3VnaCBtcHggaW5zdHJ1Y3Rpb25zIG9yCj4gICAg IGNvbXBpbGVyIGJ1aWx0aW5zKSwgZG8gd2UgZXhwZWN0IEdEQiB0byBzaG93 IHRoZXNlIG1weCBib3VuZHMgdG9vPwpOby4gU2FtZSBhcyBhYm92ZS4KPiAg IC0gSWYgcHJvZ3JhbSBzZXRzIG1weCBib3VuZHMgdGhyb3VnaCBteHAgaW5z dHJ1Y3Rpb25zIGFuZCBHREIgc2V0cyBtcHgKPiAgICAgYm91bmRzIHRvbywg ZG9lcyB0aGlzIGludGVyZmVyZSBlYWNoIG90aGVyPyBvciBwcm9ncmFtJ3Mg bXhwIGJvdW5kcwo+ICAgICBzZXR0aW5nIGlzIHN0b3JlZCBpbiBibmQwLWJu ZDMsIGJ1dCBHREIncyBtcHggYm91bmQgc2V0dGluZyBpcyBib3VuZAo+ICAg ICBkaXJlY3RvcnkgYW5kIGJvdW5kIHRhYmxlLCBzbyB0aGlzIGRvZXNuJ3Qg aW50ZXJmZXJlIGVhY2ggb3RoZXI/CgpZZXMuIExpa2UgaXQgaGFwcGVucyB3 aXRoIHZhcmlhYmxlcyBsb2NhdGlvbiBkZXBlbmRlbnQgdmFyaWFibGVzLgpU byBiZSBhYmxlIHRvIHRvIHNldCBib3VuZHMgYWxzbyBvbiByZWdpc3RlcnMg YW5kIHRhYmxlcyBhbmQgbWFrZSB0aGVtIApzeW5jIHdlIG5lZWQgZGVidWcg aW5mb3JtYXRpb24uClRoZSBzb2x1dGlvbiBieSBub3cgaXMgd2l0aG91dC4g SW4gdGhpcyBzZW5zZSB1c2VyIGhhcyB0byBrbm93IGEgYml0IG9mIAphc3Nl bWJsZXIgdG8ga25vdyB3aGVyZSB0byBzZXQgdGhlIGJvdW5kcywgZm9yIHRo ZSBjYXNlIGl0IGJlaW5nIGRlYnVnZ2VkLgoKPj4gMi4gU2hvdWxkIGluaXRp YWxpemF0aW9uIG1vdmUgdG8gdGhlIHZhbGlkYXRpb24gcm91dGluZT8KPiBJ ZiB3ZSBkbyBzbywgY29tbWFuZHMgYXJlIG5vdCBzaG93biB1cCBvbiB0aGUg dGFyZ2V0IGRvZXNuJ3QgbWVldCB0aGUgcmVxdWlyZW1lbnRzIG9mIGNvbW1h bmRzLiAgQWZ0ZXIgc29tZSB0aGlua2luZywgSSBwcmVmZXIgcmVnaXN0ZXJp bmcgbXB4IGNvbW1hbmRzIHVuY29uZGl0aW9uYWxseSBldmVuIHRhcmdldCBk b2Vzbid0IHN1cHBvcnQgbXB4LiAgVGhlICJzaG93IiBjb21tYW5kIHN0aWxs IGNhbiB0ZWxsIHVzZXIgdGhhdCB0aGlzIGNvbW1hbmQgZG9lc24ndCB3b3Jr IG9uIHRoaXMgdGFyZ2V0LiAgT3RoZXJ3aXNlLCBpdCBzaG91bGQgYmUgY29u ZnVzaW5nIHRoYXQgc29tZSBjb21tYW5kcyBkaXNhcHBlYXIgc2lsZW50bHkK PiAtLQo+IFlhbyAo6b2Q5bCnKQoKSG9wZSBJIGhhdmUgYW5zd2VyZWQgeW91 ciBxdWVzdGlvbnMuCgpUaGFua3MgYSBsb3QgYW5kIGJlc3QgcmVnYXJkcywK LUZyZWQKSW50ZWwgR21iSApEb3JuYWNoZXIgU3RyYXNzZSAxCjg1NjIyIEZl bGRraXJjaGVuL011ZW5jaGVuLCBEZXV0c2NobGFuZApTaXR6IGRlciBHZXNl bGxzY2hhZnQ6IEZlbGRraXJjaGVuIGJlaSBNdWVuY2hlbgpHZXNjaGFlZnRz ZnVlaHJlcjogQ2hyaXN0aWFuIExhbXByZWNodGVyLCBIYW5uZXMgU2Nod2Fk ZXJlciwgRG91Z2xhcyBMdXNrClJlZ2lzdGVyZ2VyaWNodDogTXVlbmNoZW4g SFJCIDQ3NDU2ClVzdC4tSWROci4vVkFUIFJlZ2lzdHJhdGlvbiBOby46IERF MTI5Mzg1ODk1CkNpdGliYW5rIEZyYW5rZnVydCBhLk0uIChCTFogNTAyIDEw OSAwMCkgNjAwMTE5MDUyCg== >From gdb-patches-return-123933-listarch-gdb-patches=sources.redhat.com@sourceware.org Wed Jul 01 09:44:11 2015 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 43742 invoked by alias); 1 Jul 2015 09:44:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 43722 invoked by uid 89); 1 Jul 2015 09:44:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 01 Jul 2015 09:44:05 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 7DB5A2CD808; Wed, 1 Jul 2015 09:44:04 +0000 (UTC) Received: from [10.36.112.46] (ovpn-112-46.ams2.redhat.com [10.36.112.46]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t619i2Nu028946; Wed, 1 Jul 2015 05:44:03 -0400 Message-ID: <5593B661.8060403@redhat.com> Date: Wed, 01 Jul 2015 09:44:00 -0000 From: Phil Muldoon MIME-Version: 1.0 To: Joel Brobecker , Jan Kratochvil CC: gdb-patches@sourceware.org Subject: Re: [patchv2] compile: Fix crash on cv-qualified self-reference References: <20150418172843.GA17777@host1.jankratochvil.net> <20150516132555.GB17266@host1.jankratochvil.net> <20150630195707.GA10987@adacore.com> In-Reply-To: <20150630195707.GA10987@adacore.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg00004.txt.bz2 Content-length: 421 On 30/06/15 20:57, Joel Brobecker wrote: > Would anyone be in a better position to review this patch? > It's one patch identified as a blocking issue before we create > the GDB 7.10 branch. It looks reasonable to me, but I can only > do a superficial review... > > I think its fine, but no, not really. It's just Jan and I on the GDB side of the compile command. A maintainer will have to sign off on it. Cheers Phil