From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 47170 invoked by alias); 30 Jun 2015 17:07:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 47154 invoked by uid 89); 30 Jun 2015 17:07:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 30 Jun 2015 17:07:23 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id ACF7E359A51; Tue, 30 Jun 2015 17:07:21 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t5UH7K4t012735; Tue, 30 Jun 2015 13:07:20 -0400 Message-ID: <5592CCC7.5080101@redhat.com> Date: Tue, 30 Jun 2015 17:07:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Patrick Palka , gdb-patches@sourceware.org Subject: Re: [PATCH 3/3] Replace TUI's select_frame hook (PR tui/13378) References: <5592B9F9.2090208@redhat.com> <1435682400-7595-1-git-send-email-patrick@parcs.ath.cx> In-Reply-To: <1435682400-7595-1-git-send-email-patrick@parcs.ath.cx> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-06/txt/msg00655.txt.bz2 On 06/30/2015 05:40 PM, Patrick Palka wrote: > [ I elected to go with making the print_frame_info_listing hook a no-op, since > it does not seem to regress anything. > > I noticed that "layout regs" was somewhat broken now that > tui_refresh_frame_and_register_information is called twice following a normal > stop: once in tui_normal_stop and then in tui_before_prompt. The second call > removes any highlights done to the individual registers during the first > call, because the function notices that the current snapshot of register > values is the same as the one taken during the first call. So effectively > register changes are no longer highlighted in "layout regs" since the > highlights immediately get removed. > > I don't think we should refresh register information at all in > tui_before_prompt since this observer is intended to only update frame > information following a call to "up", "down", "frame", etc. Only after the > inferior has run for a bit could registers have changed. So this patch adds > the parameter registers_too_p to tui_refresh_frame_and_register_information > to indicate wheher we should update registers too, and updates > tui_before_prompt and tui_normal_stop accordingly. ] Hmm, what about when the user changes registers with "print $rax = 1" etc.? Do we end up with stale contents? Thanks, Pedro Alves