From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-123910-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 65264 invoked by alias); 30 Jun 2015 15:11:07 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 64529 invoked by uid 89); 30 Jun 2015 15:11:06 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 30 Jun 2015 15:11:05 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (Postfix) with ESMTPS id BC8A536A9AF;	Tue, 30 Jun 2015 15:11:04 +0000 (UTC)
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t5UFB3G1007810;	Tue, 30 Jun 2015 11:11:03 -0400
Message-ID: <5592B187.20507@redhat.com>
Date: Tue, 30 Jun 2015 15:11:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Patrick Palka <patrick@parcs.ath.cx>
CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Be lazy about refreshing the windows in tui_show_frame_info (PR tui/13378)
References: <1435372525-1374-2-git-send-email-patrick@parcs.ath.cx> <1435631532-32504-1-git-send-email-patrick@parcs.ath.cx> <5592A753.4030004@redhat.com> <CA+C-WL_6V6jTry9cVFZPNtOx8D510k-Ni_=cv_riXju01rp41g@mail.gmail.com>
In-Reply-To: <CA+C-WL_6V6jTry9cVFZPNtOx8D510k-Ni_=cv_riXju01rp41g@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2015-06/txt/msg00645.txt.bz2

On 06/30/2015 03:44 PM, Patrick Palka wrote:
> On Tue, Jun 30, 2015 at 10:27 AM, Pedro Alves <palves@redhat.com> wrote:

>> Can't element->proc_name be NULL here?
> 
> Don't think so, since it is an inline array.  It's defined as:
> 
> struct tui_locator_element
> {
>   ...
>   char full_name[MAX_LOCATOR_ELEMENT_LEN];
>   char proc_name[MAX_LOCATOR_ELEMENT_LEN];
> }
> 
> (and tui_alloc_content makes sure to set full_name[0] = proc_name[0] = '\0').

Ah.

> 
>>
>> For the string fields, do we also need to compare
>> whether we go from NULL <-> non-NULL ?
>>
>>   locator_changed_p |= ((fullname == NULL) != (element->full_name == NULL));
>>
>> etc.?
> 
> Yeah, that would be more correct I think.  But I think the logic would
> have to look like "if (procname == NULL) locator_changed_p |= strlen
> (element->proc_name) != 0;" because proc_name cannot be NULL.  When
> procname is NULL, proc_name[0] gets set to 0.
> 

Or alternatively:

  if (fullname == NULL)
    fullname = "";
  locator_changed_p |= strncmp (element->proc_name, procname,
				MAX_LOCATOR_ELEMENT_LEN) != 0;
  ...

Thanks,
Pedro Alves