From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 65763 invoked by alias); 30 Jun 2015 14:08:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 65747 invoked by uid 89); 30 Jun 2015 14:08:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 30 Jun 2015 14:08:49 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id B8E79AB96C; Tue, 30 Jun 2015 14:08:48 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t5UE8lVt021251; Tue, 30 Jun 2015 10:08:47 -0400 Message-ID: <5592A2EE.40900@redhat.com> Date: Tue, 30 Jun 2015 14:08:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Patrick Palka , gdb-patches@sourceware.org Subject: Re: [PATCH 3/3] Replace TUI's select_frame hook (PR tui/13378) References: <1435667837-16337-1-git-send-email-patrick@parcs.ath.cx> In-Reply-To: <1435667837-16337-1-git-send-email-patrick@parcs.ath.cx> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-06/txt/msg00635.txt.bz2 On 06/30/2015 01:37 PM, Patrick Palka wrote: > This version adds a tui_normal_stop observer in place of augmenting the > tui_on_sync_execution_done observer. And tui_refresh_frame_and_register_information > can now be made a static function. > > The observer takes a print_frame parameter that is supposed to inform us > whether the frame should be printed. This boolean seems to only be true for s/only be true/only be false/ > when the inferior has exited. Since tui_refresh_frame_and_register_information > already handles this case by checking has_stack_frames() this patch elects to > ignore this parameter in the observer. This is OK. I'll take a look at patch 2 soon. Did you find that we still need deprecated_print_frame_info_listing_hook? Thanks, Pedro Alves